The new ocaml compiler (4.00) has a lot of very cool warnings,

especially about unused definitions, unused opens and unused rec
flags.

The following patch uses information gathered using these warnings to
clean Coq source tree. In this patch, I focused on warnings whose fix
are very unlikely to introduce bugs.

(a) "unused rec flags". They cannot change the semantics of the program
    but only allow the inliner to do a better job.

(b) "unused type definitions". I only removed type definitions that were
    given to functors that do not require them. Some type definitions were
    used as documentation to obtain better error messages, but were not
    ascribed to any definition. I superficially mentioned them in one
    arbitrary chosen definition to remove the warning. This is unaesthetic
    but I did not find a better way.

(c) "unused for loop index". The following idiom of imperative
    programming is used at several places: "for i = 1 to n do
    that_side_effect () done".  I replaced "i" with "_i" to remove the
    warning... but, there is a combinator named "Util.repeat" that
    would only cost us a function call while improving readibility.
    Should'nt we use it?

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/trunk@15797 85f007b7-540e-0410-9357-904b9bb8a0f7

1 files changed, 1 insertions, 3 deletions

diff --git a/lib/pp.ml b/lib/pp.ml
index 463e3fc3c..1899b2d3c 100644
--- a/lib/pp.ml
+++ b/lib/pp.ml
@@ -71,8 +71,6 @@ type ppcmd = (int*string) ppcmd_token
 
 type std_ppcmds = ppcmd Stream.t
 
-type 'a ppdirs = 'a ppdir_token Stream.t
-
 let is_empty s =
   try Stream.empty s; true with Stream.Failure -> false
 
@@ -175,7 +173,7 @@ let rec eval_ppcmds l =
   Stream.of_list (aux l)
 
 (* In new syntax only double quote char is escaped by repeating it *)
-let rec escape_string s =
+let escape_string s =
   let rec escape_at s i =
     if i<0 then s
     else if s.[i] == '"' then