From d30747efea01b61dba44abe50f2b7a9d8f9da3a5 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sat, 6 Sep 2014 13:30:27 -0400 Subject: core: Pass string by reference in FetchFromPortName and DeleteService --- src/core/hle/service/service.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/core/hle/service/service.cpp') diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp index d3af2768..00ac1c9c 100644 --- a/src/core/hle/service/service.cpp +++ b/src/core/hle/service/service.cpp @@ -41,7 +41,7 @@ void Manager::AddService(Interface* service) { } /// Removes a service from the manager, also frees memory -void Manager::DeleteService(std::string port_name) { +void Manager::DeleteService(const std::string& port_name) { Interface* service = FetchFromPortName(port_name); m_services.erase(std::remove(m_services.begin(), m_services.end(), service), m_services.end()); m_port_map.erase(port_name); @@ -54,7 +54,7 @@ Interface* Manager::FetchFromHandle(Handle handle) { } /// Get a Service Interface from its port -Interface* Manager::FetchFromPortName(std::string port_name) { +Interface* Manager::FetchFromPortName(const std::string& port_name) { auto itr = m_port_map.find(port_name); if (itr == m_port_map.end()) { return nullptr; -- cgit v1.2.3