// Copyright 2006-2015 Google Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package com.google.devtools.build.lib.packages; import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertWithMessage; import static com.google.devtools.build.lib.packages.Attribute.attr; import static com.google.devtools.build.lib.packages.ImplicitOutputsFunction.substitutePlaceholderIntoTemplate; import static com.google.devtools.build.lib.packages.RuleClass.NO_EXTERNAL_BINDINGS; import static com.google.devtools.build.lib.packages.Type.BOOLEAN; import static com.google.devtools.build.lib.packages.Type.INTEGER; import static com.google.devtools.build.lib.packages.Type.LABEL; import static com.google.devtools.build.lib.packages.Type.LABEL_LIST; import static com.google.devtools.build.lib.packages.Type.OUTPUT_LIST; import static com.google.devtools.build.lib.packages.Type.STRING; import static com.google.devtools.build.lib.packages.Type.STRING_LIST; import com.google.common.base.Predicate; import com.google.common.base.Predicates; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import com.google.devtools.build.lib.analysis.config.BuildConfiguration; import com.google.devtools.build.lib.cmdline.LabelSyntaxException; import com.google.devtools.build.lib.cmdline.PackageIdentifier; import com.google.devtools.build.lib.events.Event; import com.google.devtools.build.lib.events.EventCollector; import com.google.devtools.build.lib.events.EventKind; import com.google.devtools.build.lib.events.Location; import com.google.devtools.build.lib.events.Location.LineAndColumn; import com.google.devtools.build.lib.packages.Attribute.ValidityPredicate; import com.google.devtools.build.lib.packages.Package.Builder; import com.google.devtools.build.lib.packages.RuleClass.Builder.RuleClassType; import com.google.devtools.build.lib.packages.RuleClass.MissingFragmentPolicy; import com.google.devtools.build.lib.packages.util.PackageLoadingTestCase; import com.google.devtools.build.lib.syntax.Label; import com.google.devtools.build.lib.vfs.Path; import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; import java.util.Set; /** * Tests for {@link RuleClass}. */ public class RuleClassTest extends PackageLoadingTestCase { private static final RuleClass.ConfiguredTargetFactory DUMMY_CONFIGURED_TARGET_FACTORY = new RuleClass.ConfiguredTargetFactory() { @Override public Object create(Object ruleContext) throws InterruptedException { throw new IllegalStateException(); } }; private static final class DummyFragment extends BuildConfiguration.Fragment { } private static final Predicate PREFERRED_DEPENDENCY_PREDICATE = Predicates.alwaysFalse(); private static RuleClass createRuleClassA() throws LabelSyntaxException { return new RuleClass("ruleA", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("my-string-attr", STRING).mandatory().build(), attr("my-label-attr", LABEL).mandatory().legacyAllowAnyFileType() .value(Label.parseAbsolute("//default:label")).build(), attr("my-labellist-attr", LABEL_LIST).mandatory().legacyAllowAnyFileType().build(), attr("my-integer-attr", INTEGER).value(42).build(), attr("my-string-attr2", STRING).mandatory().value((String) null).build(), attr("my-stringlist-attr", STRING_LIST).build(), attr("my-sorted-stringlist-attr", STRING_LIST).orderIndependent().build()); } private static RuleClass createRuleClassB(RuleClass ruleClassA) { // emulates attribute inheritance List attributes = new ArrayList<>(ruleClassA.getAttributes()); attributes.add(attr("another-string-attr", STRING).mandatory().build()); return new RuleClass("ruleB", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attributes.toArray(new Attribute[0])); } public void testRuleClassBasics() throws Exception { RuleClass ruleClassA = createRuleClassA(); assertEquals("ruleA", ruleClassA.getName()); assertEquals(7, ruleClassA.getAttributeCount()); assertEquals(0, (int) ruleClassA.getAttributeIndex("my-string-attr")); assertEquals(1, (int) ruleClassA.getAttributeIndex("my-label-attr")); assertEquals(2, (int) ruleClassA.getAttributeIndex("my-labellist-attr")); assertEquals(3, (int) ruleClassA.getAttributeIndex("my-integer-attr")); assertEquals(4, (int) ruleClassA.getAttributeIndex("my-string-attr2")); assertEquals(5, (int) ruleClassA.getAttributeIndex("my-stringlist-attr")); assertEquals(6, (int) ruleClassA.getAttributeIndex("my-sorted-stringlist-attr")); assertEquals(ruleClassA.getAttribute(0), ruleClassA.getAttributeByName("my-string-attr")); assertEquals(ruleClassA.getAttribute(1), ruleClassA.getAttributeByName("my-label-attr")); assertEquals(ruleClassA.getAttribute(2), ruleClassA.getAttributeByName("my-labellist-attr")); assertEquals(ruleClassA.getAttribute(3), ruleClassA.getAttributeByName("my-integer-attr")); assertEquals(ruleClassA.getAttribute(4), ruleClassA.getAttributeByName("my-string-attr2")); assertEquals(ruleClassA.getAttribute(5), ruleClassA.getAttributeByName("my-stringlist-attr")); assertEquals(ruleClassA.getAttribute(6), ruleClassA.getAttributeByName("my-sorted-stringlist-attr")); assertEquals("", // default based on type ruleClassA.getAttribute(0).getDefaultValue(null)); assertEquals(Label.parseAbsolute("//default:label"), ruleClassA.getAttribute(1).getDefaultValue(null)); assertEquals(Collections.emptyList(), ruleClassA.getAttribute(2).getDefaultValue(null)); assertEquals(42, ruleClassA.getAttribute(3).getDefaultValue(null)); assertEquals(null, // default explicitly specified ruleClassA.getAttribute(4).getDefaultValue(null)); assertEquals(Collections.emptyList(), ruleClassA.getAttribute(5).getDefaultValue(null)); assertEquals(Collections.emptyList(), ruleClassA.getAttribute(6).getDefaultValue(null)); } public void testRuleClassInheritance() throws Exception { RuleClass ruleClassA = createRuleClassA(); RuleClass ruleClassB = createRuleClassB(ruleClassA); assertEquals("ruleB", ruleClassB.getName()); assertEquals(8, ruleClassB.getAttributeCount()); assertEquals(0, (int) ruleClassB.getAttributeIndex("my-string-attr")); assertEquals(1, (int) ruleClassB.getAttributeIndex("my-label-attr")); assertEquals(2, (int) ruleClassB.getAttributeIndex("my-labellist-attr")); assertEquals(3, (int) ruleClassB.getAttributeIndex("my-integer-attr")); assertEquals(4, (int) ruleClassB.getAttributeIndex("my-string-attr2")); assertEquals(5, (int) ruleClassB.getAttributeIndex("my-stringlist-attr")); assertEquals(6, (int) ruleClassB.getAttributeIndex("my-sorted-stringlist-attr")); assertEquals(7, (int) ruleClassB.getAttributeIndex("another-string-attr")); assertEquals(ruleClassB.getAttribute(0), ruleClassB.getAttributeByName("my-string-attr")); assertEquals(ruleClassB.getAttribute(1), ruleClassB.getAttributeByName("my-label-attr")); assertEquals(ruleClassB.getAttribute(2), ruleClassB.getAttributeByName("my-labellist-attr")); assertEquals(ruleClassB.getAttribute(3), ruleClassB.getAttributeByName("my-integer-attr")); assertEquals(ruleClassB.getAttribute(4), ruleClassB.getAttributeByName("my-string-attr2")); assertEquals(ruleClassB.getAttribute(5), ruleClassB.getAttributeByName("my-stringlist-attr")); assertEquals(ruleClassB.getAttribute(6), ruleClassB.getAttributeByName("my-sorted-stringlist-attr")); assertEquals(ruleClassB.getAttribute(7), ruleClassB.getAttributeByName("another-string-attr")); } private static final String TEST_PACKAGE_NAME = "testpackage"; private static final String TEST_RULE_NAME = "my-rule-A"; private static final int TEST_RULE_DEFINED_AT_LINE = 42; private static final String TEST_RULE_LABEL = "//" + TEST_PACKAGE_NAME + ":" + TEST_RULE_NAME; private Path testBuildfilePath; private Location testRuleLocation; @Override protected void setUp() throws Exception { super.setUp(); testBuildfilePath = scratch.resolve("/home/user/workspace/testpackage/BUILD"); testRuleLocation = Location.fromPathAndStartColumn( testBuildfilePath.asFragment(), 0, 0, new LineAndColumn(TEST_RULE_DEFINED_AT_LINE, 0)); } private Package.Builder createDummyPackageBuilder() { return new Builder(PackageIdentifier.createInDefaultRepo(TEST_PACKAGE_NAME), "TESTING") .setFilename(testBuildfilePath) .setMakeEnv(new MakeEnvironment.Builder()); } public void testDuplicatedDeps() throws Exception { RuleClass depsRuleClass = new RuleClass("ruleDeps", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("list1", LABEL_LIST).mandatory().legacyAllowAnyFileType().build(), attr("list2", LABEL_LIST).mandatory().legacyAllowAnyFileType().build(), attr("list3", LABEL_LIST).mandatory().legacyAllowAnyFileType().build()); // LinkedHashMap -> predictable iteration order for testing Map attributeValues = new LinkedHashMap<>(); attributeValues.put("list1", Lists.newArrayList("//testpackage:dup1", ":dup1", ":nodup")); attributeValues.put("list2", Lists.newArrayList(":nodup1", ":nodup2")); attributeValues.put("list3", Lists.newArrayList(":dup1", ":dup1", ":dup2", ":dup2")); reporter.removeHandler(failFastHandler); createRule(depsRuleClass, "depsRule", attributeValues, testRuleLocation); assertSame(3, eventCollector.count()); assertDupError("//testpackage:dup1", "list1", "depsRule"); assertDupError("//testpackage:dup1", "list3", "depsRule"); assertDupError("//testpackage:dup2", "list3", "depsRule"); } private void assertDupError(String label, String attrName, String ruleName) { assertContainsEvent(String.format("Label '%s' is duplicated in the '%s' attribute of rule '%s'", label, attrName, ruleName)); } public void testCreateRuleWithLegacyPublicVisibility() throws Exception { RuleClass ruleClass = new RuleClass("ruleVis", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("visibility", LABEL_LIST).legacyAllowAnyFileType().build()); Map attributeValues = new HashMap<>(); attributeValues.put("visibility", Arrays.asList("//visibility:legacy_public")); reporter.removeHandler(failFastHandler); EventCollector collector = new EventCollector(EventKind.ERRORS); reporter.addHandler(collector); createRule(ruleClass, TEST_RULE_NAME, attributeValues, testRuleLocation); assertContainsEvent("//visibility:legacy_public only allowed in package declaration"); } public void testCreateRule() throws Exception { RuleClass ruleClassA = createRuleClassA(); // LinkedHashMap -> predictable iteration order for testing Map attributeValues = new LinkedHashMap<>(); attributeValues.put("my-labellist-attr", "foobar"); // wrong type attributeValues.put("bogus-attr", "foobar"); // no such attr attributeValues.put("my-stringlist-attr", Arrays.asList("foo", "bar")); reporter.removeHandler(failFastHandler); EventCollector collector = new EventCollector(EventKind.ERRORS); reporter.addHandler(collector); Rule rule = createRule(ruleClassA, TEST_RULE_NAME, attributeValues, testRuleLocation); // TODO(blaze-team): (2009) refactor to use assertContainsEvent Iterator expectedMessages = Arrays.asList( "expected value of type 'list(label)' for attribute 'my-labellist-attr' " + "in 'ruleA' rule, but got \"foobar\" (string)", "no such attribute 'bogus-attr' in 'ruleA' rule", "missing value for mandatory " + "attribute 'my-string-attr' in 'ruleA' rule", "missing value for mandatory attribute 'my-label-attr' in 'ruleA' rule", "missing value for mandatory " + "attribute 'my-labellist-attr' in 'ruleA' rule", "missing value for mandatory " + "attribute 'my-string-attr2' in 'ruleA' rule" ).iterator(); for (Event event : collector) { assertEquals(TEST_RULE_DEFINED_AT_LINE, event.getLocation().getStartLineAndColumn().getLine()); assertEquals(testBuildfilePath.asFragment(), event.getLocation().getPath()); assertEquals(TEST_RULE_LABEL + ": " + expectedMessages.next(), event.getMessage()); } // Test basic rule properties: assertEquals("ruleA", rule.getRuleClass()); assertEquals(TEST_RULE_NAME, rule.getName()); assertEquals(TEST_RULE_LABEL, rule.getLabel().toString()); // Test attribute access: AttributeMap attributes = RawAttributeMapper.of(rule); assertEquals("//default:label", attributes.get("my-label-attr", Type.LABEL).toString()); assertEquals(42, attributes.get("my-integer-attr", Type.INTEGER).intValue()); assertEquals("", // missing attribute -> default chosen based on type attributes.get("my-string-attr", Type.STRING)); assertThat(attributes.get("my-labellist-attr", Type.LABEL_LIST)).isEmpty(); assertEquals(Arrays.asList("foo", "bar"), attributes.get("my-stringlist-attr", Type.STRING_LIST)); try { attributes.get("my-labellist-attr", Type.STRING); // wrong type fail(); } catch (IllegalArgumentException e) { assertThat(e).hasMessage("Attribute my-labellist-attr is not of type string " + "in rule //testpackage:my-rule-A"); } } public void testImplicitOutputs() throws Exception { RuleClass ruleClassC = new RuleClass("ruleC", false, false, false, false, false, false, ImplicitOutputsFunction.fromTemplates("foo-%{name}.bar", "lib%{name}-wazoo-%{name}.mumble", "stuff-%{outs}-bar"), RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("outs", OUTPUT_LIST).build()); Map attributeValues = new HashMap<>(); attributeValues.put("outs", Collections.singletonList("explicit_out")); Rule rule = createRule(ruleClassC, "myrule", attributeValues, testRuleLocation); Set set = new HashSet<>(); for (OutputFile outputFile : rule.getOutputFiles()) { set.add(outputFile.getName()); assertSame(rule, outputFile.getGeneratingRule()); } assertThat(set).containsExactly("foo-myrule.bar", "libmyrule-wazoo-myrule.mumble", "stuff-explicit_out-bar", "explicit_out"); } public void testImplicitOutsWithBasenameDirname() throws Exception { RuleClass ruleClass = new RuleClass("ruleClass", false, false, false, false, false, false, ImplicitOutputsFunction.fromTemplates("%{dirname}lib%{basename}.bar"), RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true); Rule rule = createRule(ruleClass, "myRule", Collections.emptyMap(), testRuleLocation); assertEquals("libmyRule.bar", Iterables.getOnlyElement(rule.getOutputFiles()).getName()); Rule ruleWithSlash = createRule(ruleClass, "myRule/with/slash", Collections.emptyMap(), testRuleLocation); assertEquals("myRule/with/libslash.bar", Iterables.getOnlyElement(ruleWithSlash.getOutputFiles()).getName()); } /** * Helper routine that instantiates a rule class with the given computed default and supporting * attributes for the default to reference. */ private static RuleClass getRuleClassWithComputedDefault(Attribute computedDefault) { return new RuleClass("ruleClass", false, false, false, false, false, false, ImplicitOutputsFunction.fromTemplates("empty"), RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("condition", BOOLEAN).value(false).build(), attr("declared1", BOOLEAN).value(false).build(), attr("declared2", BOOLEAN).value(false).build(), attr("nonconfigurable", BOOLEAN).nonconfigurable("test").value(false).build(), computedDefault); } /** * Helper routine that checks that a computed default is valid and bound to the expected value. */ private void checkValidComputedDefault(Object expectedValue, Attribute computedDefault, ImmutableMap attrValueMap) throws Exception { assertTrue(computedDefault.getDefaultValueForTesting() instanceof Attribute.ComputedDefault); Rule rule = createRule(getRuleClassWithComputedDefault(computedDefault), "myRule", attrValueMap, testRuleLocation); AttributeMap attributes = RawAttributeMapper.of(rule); assertEquals( expectedValue, attributes.get(computedDefault.getName(), computedDefault.getType())); } /** * Helper routine that checks that a computed default is invalid due to declared dependency * issues and fails with the expected message. */ private void checkInvalidComputedDefault(Attribute computedDefault, String expectedMessage) throws Exception { try { createRule(getRuleClassWithComputedDefault(computedDefault), "myRule", ImmutableMap.of(), testRuleLocation); fail("Expected computed default \"" + computedDefault.getName() + "\" to fail with " + "declaration errors"); } catch (IllegalArgumentException e) { // Expected outcome. assertThat(e).hasMessage(expectedMessage); } } /** * Tests computed default values are computed as expected. */ public void testComputedDefault() throws Exception { Attribute computedDefault = attr("$result", BOOLEAN).value(new Attribute.ComputedDefault("condition") { @Override public Object getDefault(AttributeMap rule) { return rule.get("condition", Type.BOOLEAN); } }).build(); checkValidComputedDefault(Boolean.FALSE, computedDefault, ImmutableMap.of("condition", Boolean.FALSE)); checkValidComputedDefault(Boolean.TRUE, computedDefault, ImmutableMap.of("condition", Boolean.TRUE)); } /** * Tests that computed defaults can only read attribute values for configurable attributes that * have been explicitly declared. */ public void testComputedDefaultDeclarations() throws Exception { checkValidComputedDefault( Boolean.FALSE, attr("$good_default_no_declares", BOOLEAN).value( new Attribute.ComputedDefault() { @Override public Object getDefault(AttributeMap rule) { // OK: not a value check: return rule.isAttributeValueExplicitlySpecified("undeclared"); } }).build(), ImmutableMap.of()); checkValidComputedDefault( Boolean.FALSE, attr("$good_default_one_declare", BOOLEAN).value( new Attribute.ComputedDefault("declared1") { @Override public Object getDefault(AttributeMap rule) { return rule.get("declared1", Type.BOOLEAN); } }).build(), ImmutableMap.of()); checkValidComputedDefault( Boolean.FALSE, attr("$good_default_two_declares", BOOLEAN).value( new Attribute.ComputedDefault("declared1", "declared2") { @Override public Object getDefault(AttributeMap rule) { return rule.get("declared1", Type.BOOLEAN) && rule.get("declared2", Type.BOOLEAN); } }).build(), ImmutableMap.of()); checkInvalidComputedDefault( attr("$bad_default_no_declares", BOOLEAN).value( new Attribute.ComputedDefault() { @Override public Object getDefault(AttributeMap rule) { return rule.get("declared1", Type.BOOLEAN); } }).build(), "attribute \"declared1\" isn't available in this computed default context"); checkInvalidComputedDefault( attr("$bad_default_one_declare", BOOLEAN).value( new Attribute.ComputedDefault("declared1") { @Override public Object getDefault(AttributeMap rule) { return rule.get("declared1", Type.BOOLEAN) || rule.get("declared2", Type.BOOLEAN); } }).build(), "attribute \"declared2\" isn't available in this computed default context"); checkInvalidComputedDefault( attr("$bad_default_two_declares", BOOLEAN).value( new Attribute.ComputedDefault("declared1", "declared2") { @Override public Object getDefault(AttributeMap rule) { return rule.get("condition", Type.BOOLEAN); } }).build(), "attribute \"condition\" isn't available in this computed default context"); } /** * Tests that computed defaults *can* read attribute values for non-configurable attributes * without needing to explicitly declare them. */ public void testComputedDefaultWithNonConfigurableAttributes() throws Exception { checkValidComputedDefault( Boolean.FALSE, attr("$good_default_reading_undeclared_nonconfigurable_attribute", BOOLEAN).value( new Attribute.ComputedDefault() { @Override public Object getDefault(AttributeMap rule) { return rule.get("nonconfigurable", Type.BOOLEAN); } }).build(), ImmutableMap.of()); } public void testOutputsAreOrdered() throws Exception { RuleClass ruleClassC = new RuleClass("ruleC", false, false, false, false, false, false, ImplicitOutputsFunction.fromTemplates("first-%{name}", "second-%{name}", "out-%{outs}"), RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("outs", OUTPUT_LIST).build()); Map attributeValues = new HashMap<>(); attributeValues.put("outs", ImmutableList.of("third", "fourth")); Rule rule = createRule(ruleClassC, "myrule", attributeValues, testRuleLocation); List actual = new ArrayList<>(); for (OutputFile outputFile : rule.getOutputFiles()) { actual.add(outputFile.getName()); assertSame(rule, outputFile.getGeneratingRule()); } assertWithMessage("unexpected output set").that(actual).containsExactly("first-myrule", "second-myrule", "out-third", "out-fourth", "third", "fourth"); assertWithMessage("invalid output ordering").that(actual).containsExactly("first-myrule", "second-myrule", "out-third", "out-fourth", "third", "fourth").inOrder(); } public void testSubstitutePlaceholderIntoTemplate() throws Exception { RuleClass ruleClass = new RuleClass("ruleA", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attr("a", STRING_LIST).mandatory().build(), attr("b", STRING_LIST).mandatory().build(), attr("c", STRING_LIST).mandatory().build(), attr("baz", STRING_LIST).mandatory().build(), attr("empty", STRING_LIST).build()); Map attributeValues = new LinkedHashMap<>(); attributeValues.put("a", ImmutableList.of("a", "A")); attributeValues.put("b", ImmutableList.of("b", "B")); attributeValues.put("c", ImmutableList.of("c", "C")); attributeValues.put("baz", ImmutableList.of("baz", "BAZ")); attributeValues.put("empty", ImmutableList.of()); AttributeMap rule = RawAttributeMapper.of( createRule(ruleClass, "testrule", attributeValues, testRuleLocation)); assertThat(substitutePlaceholderIntoTemplate("foo", rule)).containsExactly("foo"); assertThat(substitutePlaceholderIntoTemplate("foo-%{baz}-bar", rule)).containsExactly( "foo-baz-bar", "foo-BAZ-bar").inOrder(); assertThat(substitutePlaceholderIntoTemplate("%{a}-%{b}-%{c}", rule)).containsExactly("a-b-c", "a-b-C", "a-B-c", "a-B-C", "A-b-c", "A-b-C", "A-B-c", "A-B-C").inOrder(); assertThat(substitutePlaceholderIntoTemplate("%{a", rule)).containsExactly("%{a"); assertThat(substitutePlaceholderIntoTemplate("%{a}}", rule)).containsExactly("a}", "A}") .inOrder(); assertThat(substitutePlaceholderIntoTemplate("x%{a}y%{empty}", rule)).isEmpty(); } public void testOrderIndependentAttribute() throws Exception { RuleClass ruleClassA = createRuleClassA(); List list = Arrays.asList("foo", "bar", "baz"); Map attributeValues = new LinkedHashMap<>(); // mandatory values attributeValues.put("my-string-attr", ""); attributeValues.put("my-label-attr", "//project"); attributeValues.put("my-string-attr2", ""); attributeValues.put("my-labellist-attr", Collections.emptyList()); // to compare the effect of .orderIndependent() attributeValues.put("my-stringlist-attr", list); attributeValues.put("my-sorted-stringlist-attr", list); Rule rule = createRule(ruleClassA, "testrule", attributeValues, testRuleLocation); AttributeMap attributes = RawAttributeMapper.of(rule); assertEquals(list, attributes.get("my-stringlist-attr", Type.STRING_LIST)); assertEquals(Arrays.asList("bar", "baz", "foo"), attributes.get("my-sorted-stringlist-attr", Type.STRING_LIST)); } public void testNonEmptyGood() throws Exception { RuleClass mneRuleClass = setupNonEmpty( attr("list1", LABEL_LIST).mandatory().legacyAllowAnyFileType().build(), attr("list2", LABEL_LIST).nonEmpty().legacyAllowAnyFileType().build(), attr("list3", STRING_LIST).nonEmpty().build()); Map attributeValues = new LinkedHashMap<>(); attributeValues.put("list1", Lists.newArrayList()); attributeValues.put("list2", Lists.newArrayList(":nodup1", ":nodup2")); attributeValues.put("list3", Lists.newArrayList("val1", "val2")); createRule(mneRuleClass, "ruleTestMNE", attributeValues, testRuleLocation); } public void testNonEmptyFail() throws Exception { RuleClass mandNonEmptyRuleClass = setupNonEmpty( attr("list", LABEL_LIST).nonEmpty().legacyAllowAnyFileType().build()); Map attributeValues = new LinkedHashMap<>(); attributeValues.put("list", Lists.newArrayList()); reporter.removeHandler(failFastHandler); createRule(mandNonEmptyRuleClass, "ruleTestMNE", attributeValues, testRuleLocation); assertSame(1, eventCollector.count()); assertContainsEvent(getErrorMsgNonEmptyList( "list", "ruleMNE", "//testpackage:ruleTestMNE")); } private RuleClass setupNonEmpty(Attribute... attributes) { RuleClass mandNonEmptyRuleClass = new RuleClass( "ruleMNE", false, false, false, false, false, false, ImplicitOutputsFunction.NONE, RuleClass.NO_CHANGE, DUMMY_CONFIGURED_TARGET_FACTORY, PredicatesWithMessage.alwaysTrue(), PREFERRED_DEPENDENCY_PREDICATE, ImmutableSet.>of(), null, NO_EXTERNAL_BINDINGS, null, ImmutableSet.>of(), MissingFragmentPolicy.FAIL_ANALYSIS, true, attributes); return mandNonEmptyRuleClass; } public void testNonEmptyWrongDefVal() throws Exception { List