// Copyright 2015 The Bazel Authors. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package com.google.devtools.build.lib.cmdline; import static com.google.common.truth.Truth.assertThat; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import com.google.devtools.build.lib.testutil.TestUtils; import com.google.devtools.build.lib.vfs.PathFragment; import java.util.regex.Pattern; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; /** * Tests for {@link Label}. */ @RunWith(JUnit4.class) public class LabelTest { private static final String BAD_PACKAGE_CHARS = "package names may contain only"; private static final String INVALID_TARGET_NAME = "invalid target name"; private static final String INVALID_PACKAGE_NAME = "invalid package name"; @Test public void testAbsolute() throws Exception { { Label l = Label.parseAbsolute("//foo/bar:baz"); assertEquals("foo/bar", l.getPackageName()); assertEquals("baz", l.getName()); } { Label l = Label.parseAbsolute("//foo/bar"); assertEquals("foo/bar", l.getPackageName()); assertEquals("bar", l.getName()); } { Label l = Label.parseAbsolute("//:bar"); assertEquals("", l.getPackageName()); assertEquals("bar", l.getName()); } { Label l = Label.parseAbsolute("@foo"); assertEquals("@foo", l.getPackageIdentifier().getRepository().getName()); assertEquals("", l.getPackageName()); assertEquals("foo", l.getName()); } } private static String parseCommandLine(String label, String prefix) throws LabelSyntaxException { return Label.parseCommandLineLabel(label, new PathFragment(prefix)).toString(); } @Test public void testLabelResolution() throws Exception { assertEquals("//absolute:label", parseCommandLine("//absolute:label", "")); assertEquals("//absolute:label", parseCommandLine("//absolute:label", "absolute")); assertEquals("//absolute:label", parseCommandLine(":label", "absolute")); assertEquals("//absolute:label", parseCommandLine("label", "absolute")); assertEquals("//absolute:label", parseCommandLine("absolute:label", "")); assertEquals("//absolute/path:label", parseCommandLine("path:label", "absolute")); assertEquals("//absolute/path:label/path", parseCommandLine("path:label/path", "absolute")); assertEquals("//absolute:label/path", parseCommandLine("label/path", "absolute")); } @Test public void testLabelResolutionAbsolutePath() throws Exception { try { parseCommandLine("//absolute:label", "/absolute"); fail(); } catch (IllegalArgumentException e) { // Expected exception } } @Test public void testLabelResolutionBadSyntax() throws Exception { try { parseCommandLine("//absolute:A+bad%syntax", ""); fail(); } catch (LabelSyntaxException e) { // Expected exception } } @Test public void testGetRelativeWithAbsoluteLabel() throws Exception { Label base = Label.parseAbsolute("//foo/bar:baz"); Label l = base.getRelative("//p1/p2:target"); assertEquals("p1/p2", l.getPackageName()); assertEquals("target", l.getName()); } @Test public void testGetRelativeWithRelativeLabel() throws Exception { Label base = Label.parseAbsolute("//foo/bar:baz"); Label l = base.getRelative(":quux"); assertEquals("foo/bar", l.getPackageName()); assertEquals("quux", l.getName()); } @Test public void testGetRelativeWithIllegalLabel() throws Exception { Label base = Label.parseAbsolute("//foo/bar:baz"); try { base.getRelative("/p1/p2:target"); fail(); } catch (LabelSyntaxException e) { /* ok */ } try { base.getRelative("quux:"); fail(); } catch (LabelSyntaxException e) { /* ok */ } try { base.getRelative(":"); fail(); } catch (LabelSyntaxException e) { /* ok */ } try { base.getRelative("::"); fail(); } catch (LabelSyntaxException e) { /* ok */ } } @Test public void testGetRelativeWithDifferentRepo() throws Exception { PackageIdentifier packageId = PackageIdentifier.create("@repo", new PathFragment("foo")); Label base = Label.create(packageId, "bar"); Label relative = base.getRelative("@remote//x:y"); assertEquals(RepositoryName.create("@remote"), relative.getPackageIdentifier().getRepository()); assertEquals(new PathFragment("x"), relative.getPackageFragment()); assertEquals("y", relative.getName()); } @Test public void testGetRelativeWithRepoLocalAbsoluteLabel() throws Exception { PackageIdentifier packageId = PackageIdentifier.create("@repo", new PathFragment("foo")); Label base = Label.create(packageId, "bar"); Label relative = base.getRelative("//x:y"); assertEquals(packageId.getRepository(), relative.getPackageIdentifier().getRepository()); assertEquals(new PathFragment("x"), relative.getPackageFragment()); assertEquals("y", relative.getName()); } @Test public void testGetRelativeWithLocalRepoRelativeLabel() throws Exception { PackageIdentifier packageId = PackageIdentifier.create("@repo", new PathFragment("foo")); Label base = Label.create(packageId, "bar"); Label relative = base.getRelative(":y"); assertEquals(packageId.getRepository(), relative.getPackageIdentifier().getRepository()); assertEquals(new PathFragment("foo"), relative.getPackageFragment()); assertEquals("y", relative.getName()); } @Test public void testGetRelativeWithRepoAndReservedPackage() throws Exception { PackageIdentifier packageId = PackageIdentifier.create("@repo", new PathFragment("foo")); Label base = Label.create(packageId, "bar"); Label relative = base.getRelative("//conditions:default"); PackageIdentifier expected = PackageIdentifier.createInMainRepo("conditions"); assertEquals(expected.getRepository(), relative.getPackageIdentifier().getRepository()); assertEquals(expected.getPackageFragment(), relative.getPackageFragment()); assertEquals("default", relative.getName()); } @Test public void testGetRelativeWithRemoteRepoToDefaultRepo() throws Exception { PackageIdentifier packageId = PackageIdentifier.create("@repo", new PathFragment("foo")); Label base = Label.create(packageId, "bar"); Label relative = base.getRelative("@//x:y"); assertEquals(RepositoryName.create("@"), relative.getPackageIdentifier().getRepository()); assertEquals(new PathFragment("x"), relative.getPackageFragment()); assertEquals("y", relative.getName()); } @Test public void testGetRepositoryRelative() throws Exception { Label defaultBase = Label.parseAbsolute("//foo/bar:baz"); Label repoBase = Label.parseAbsolute("@repo//foo/bar:baz"); Label mainBase = Label.parseAbsolute("@//foo/bar:baz"); Label externalTarget = Label.parseAbsolute("//external:target"); Label l = defaultBase.resolveRepositoryRelative(externalTarget); assertTrue(l.getPackageIdentifier().getRepository().isMain()); assertEquals("external", l.getPackageName()); assertEquals("target", l.getName()); assertEquals(l, repoBase.resolveRepositoryRelative(externalTarget)); assertEquals(l, mainBase.resolveRepositoryRelative(externalTarget)); } @Test public void testFactory() throws Exception { Label l = Label.create("foo/bar", "quux"); assertEquals("foo/bar", l.getPackageName()); assertEquals("quux", l.getName()); } @Test public void testIdentities() throws Exception { Label l1 = Label.parseAbsolute("//foo/bar:baz"); Label l2 = Label.parseAbsolute("//foo/bar:baz"); Label l3 = Label.parseAbsolute("//foo/bar:quux"); assertEquals(l1, l1); assertEquals(l1, l2); assertEquals(l2, l1); assertEquals(l1, l2); assertFalse(l3.equals(l1)); assertFalse(l1.equals(l3)); assertEquals(l1.hashCode(), l2.hashCode()); } @Test public void testToString() throws Exception { { String s = "@//foo/bar:baz"; Label l = Label.parseAbsolute(s); assertEquals("//foo/bar:baz", l.toString()); } { Label l = Label.parseAbsolute("//foo/bar"); assertEquals("//foo/bar:bar", l.toString()); } { Label l = Label.parseAbsolute("@foo"); assertEquals("@foo//:foo", l.toString()); } } @Test public void testDotDot() throws Exception { Label.parseAbsolute("//foo/bar:baz..gif"); } /** * Asserts that creating a label throws a SyntaxException. * @param label the label to create. */ private static void assertSyntaxError(String expectedError, String label) { try { Label.parseAbsolute(label); fail("Label '" + label + "' did not contain a syntax error"); } catch (LabelSyntaxException e) { assertThat(e.getMessage()).containsMatch(Pattern.quote(expectedError)); } } @Test public void testBadCharacters() throws Exception { assertSyntaxError("package names may contain only", "//foo/bar baz"); assertSyntaxError("target names may not contain ':'", "//foo:bar:baz"); assertSyntaxError("target names may not contain ':'", "//foo:bar:"); assertSyntaxError("target names may not contain ':'", "//foo/bar::"); assertSyntaxError("target names may not contain '&'", "//foo:bar&"); assertSyntaxError("target names may not contain '$'", "//foo/bar:baz$a"); assertSyntaxError("target names may not contain '('", "//foo/bar:baz(foo)"); assertSyntaxError("target names may not contain ')'", "//foo/bar:bazfoo)"); // Warning: if these assertions are false, tools that assume that they can safely quote labels // may need to be fixed. Please consult with bazel-dev before loosening these restrictions. assertSyntaxError("target names may not contain '''", "//foo/bar:baz'foo"); assertSyntaxError("target names may not contain '\"'", "//foo/bar:baz\"foo"); } @Test public void testUplevelReferences() throws Exception { assertSyntaxError(INVALID_PACKAGE_NAME, "//foo/bar/..:baz"); assertSyntaxError(INVALID_PACKAGE_NAME, "//foo/../baz:baz"); assertSyntaxError(INVALID_PACKAGE_NAME, "//../bar/baz:baz"); assertSyntaxError(INVALID_PACKAGE_NAME, "//..:foo"); assertSyntaxError(INVALID_TARGET_NAME, "//foo:bar/../baz"); assertSyntaxError(INVALID_TARGET_NAME, "//foo:../bar/baz"); assertSyntaxError(INVALID_TARGET_NAME, "//foo:bar/baz/.."); assertSyntaxError(INVALID_TARGET_NAME, "//foo:.."); } @Test public void testDotAsAPathSegment() throws Exception { assertSyntaxError(INVALID_PACKAGE_NAME, "//foo/bar/.:baz"); assertSyntaxError(INVALID_PACKAGE_NAME, "//foo/./baz:baz"); assertSyntaxError(INVALID_PACKAGE_NAME, "//./bar/baz:baz"); assertSyntaxError(INVALID_TARGET_NAME, "//foo:bar/./baz"); assertSyntaxError(INVALID_TARGET_NAME, "//foo:./bar/baz"); // TODO(bazel-team): enable when we have removed the "Workaround" in Label // that rewrites broken Labels by removing the trailing '.' //assertSyntaxError(INVALID_PACKAGE_NAME, // "//foo:bar/baz/."); //assertSyntaxError(INVALID_PACKAGE_NAME, // "//foo:."); } @Test public void testTrailingDotSegment() throws Exception { assertEquals(Label .parseAbsolute("//foo:dir/."), Label .parseAbsolute("//foo:dir")); } @Test public void testSomeOtherBadLabels() throws Exception { assertSyntaxError("package names may not end with '/'", "//foo/:bar"); assertSyntaxError("package names may not start with '/'", "///p:foo"); assertSyntaxError("package names may not contain '//' path separators", "//a//b:foo"); } @Test public void testSomeGoodLabels() throws Exception { Label.parseAbsolute("//foo:..bar"); Label.parseAbsolute("//Foo:..bar"); Label.parseAbsolute("//-Foo:..bar"); Label.parseAbsolute("//00:..bar"); Label.parseAbsolute("//package:foo+bar"); Label.parseAbsolute("//package:foo_bar"); Label.parseAbsolute("//package:foo=bar"); Label.parseAbsolute("//package:foo-bar"); Label.parseAbsolute("//package:foo.bar"); Label.parseAbsolute("//package:foo@bar"); Label.parseAbsolute("//package:foo~bar"); } /** * Regression test: we previously expanded the set of characters which are considered label chars * to include "@" (see test above). An unexpected side-effect is that "@D" in genrule(cmd) was * considered to be a valid relative label! The fix is to forbid "@x" in package names. */ @Test public void testAtVersionIsIllegal() throws Exception { assertSyntaxError(BAD_PACKAGE_CHARS, "//foo/bar@123:baz"); } @Test public void testDoubleSlashPathSeparator() throws Exception { assertSyntaxError("package names may not contain '//' path separators", "//foo//bar:baz"); assertSyntaxError("target names may not contain '//' path separator", "//foo:bar//baz"); } @Test public void testNonPrintableCharacters() throws Exception { assertSyntaxError( "target names may not contain non-printable characters: '\\x02'", "//foo:..\002bar"); } /** Make sure that control characters - such as CR - are escaped on output. */ @Test public void testInvalidLineEndings() throws Exception { assertSyntaxError("invalid target name '..bar\\r': " + "target names may not end with carriage returns", "//foo:..bar\r"); } @Test public void testEmptyName() throws Exception { assertSyntaxError("invalid target name '': empty target name", "//foo/bar:"); } @Test public void testSerializationSimple() throws Exception { checkSerialization("//a", 93); } @Test public void testSerializationNested() throws Exception { checkSerialization("//foo/bar:baz", 101); } @Test public void testSerializationWithoutTargetName() throws Exception { checkSerialization("//foo/bar", 101); } private void checkSerialization(String labelString, int expectedSize) throws Exception { Label a = Label.parseAbsolute(labelString); byte[] sa = TestUtils.serializeObject(a); assertEquals(expectedSize, sa.length); Label a2 = (Label) TestUtils.deserializeObject(sa); assertEquals(a, a2); } @Test public void testRepoLabel() throws Exception { Label label = Label.parseAbsolute("@foo//bar/baz:bat/boo"); assertEquals("@foo//bar/baz:bat/boo", label.toString()); } @Test public void testNoRepo() throws Exception { Label label = Label.parseAbsolute("//bar/baz:bat/boo"); assertEquals("//bar/baz:bat/boo", label.toString()); } @Test public void testInvalidRepo() throws Exception { try { Label.parseAbsolute("foo//bar/baz:bat/boo"); fail(); } catch (LabelSyntaxException e) { assertThat(e).hasMessage( "invalid repository name 'foo': workspace names must start with '@'"); } } @Test public void testGetWorkspaceRoot() throws Exception { Label label = Label.parseAbsolute("//bar/baz"); assertThat(label.getWorkspaceRoot()).isEmpty(); label = Label.parseAbsolute("@repo//bar/baz"); assertThat(label.getWorkspaceRoot()).isEqualTo("external/repo"); } }