// Copyright 2014 The Bazel Authors. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package com.google.devtools.build.lib.skyframe; import com.google.common.cache.Cache; import com.google.common.collect.ImmutableCollection; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.common.collect.Sets; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.cmdline.LabelSyntaxException; import com.google.devtools.build.lib.cmdline.PackageIdentifier; import com.google.devtools.build.lib.events.Event; import com.google.devtools.build.lib.events.Location; import com.google.devtools.build.lib.events.StoredEventHandler; import com.google.devtools.build.lib.packages.BuildFileContainsErrorsException; import com.google.devtools.build.lib.packages.BuildFileNotFoundException; import com.google.devtools.build.lib.packages.CachingPackageLocator; import com.google.devtools.build.lib.packages.Globber; import com.google.devtools.build.lib.packages.InvalidPackageNameException; import com.google.devtools.build.lib.packages.NoSuchPackageException; import com.google.devtools.build.lib.packages.Package; import com.google.devtools.build.lib.packages.PackageFactory; import com.google.devtools.build.lib.packages.Preprocessor; import com.google.devtools.build.lib.packages.Preprocessor.AstAfterPreprocessing; import com.google.devtools.build.lib.packages.RuleVisibility; import com.google.devtools.build.lib.packages.Target; import com.google.devtools.build.lib.profiler.Profiler; import com.google.devtools.build.lib.profiler.ProfilerTask; import com.google.devtools.build.lib.skyframe.GlobValue.InvalidGlobPatternException; import com.google.devtools.build.lib.skyframe.SkylarkImportLookupFunction.SkylarkImportFailedException; import com.google.devtools.build.lib.syntax.BuildFileAST; import com.google.devtools.build.lib.syntax.Environment.Extension; import com.google.devtools.build.lib.syntax.EvalException; import com.google.devtools.build.lib.syntax.ParserInputSource; import com.google.devtools.build.lib.syntax.SkylarkImport; import com.google.devtools.build.lib.syntax.Statement; import com.google.devtools.build.lib.util.Pair; import com.google.devtools.build.lib.util.Preconditions; import com.google.devtools.build.lib.vfs.FileSystemUtils; import com.google.devtools.build.lib.vfs.Path; import com.google.devtools.build.lib.vfs.PathFragment; import com.google.devtools.build.lib.vfs.RootedPath; import com.google.devtools.build.skyframe.SkyFunction; import com.google.devtools.build.skyframe.SkyFunctionException; import com.google.devtools.build.skyframe.SkyFunctionException.Transience; import com.google.devtools.build.skyframe.SkyKey; import com.google.devtools.build.skyframe.SkyValue; import com.google.devtools.build.skyframe.ValueOrException2; import com.google.devtools.build.skyframe.ValueOrException3; import com.google.devtools.build.skyframe.ValueOrException4; import java.io.IOException; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; import java.util.LinkedHashSet; import java.util.List; import java.util.Map; import java.util.Map.Entry; import java.util.Set; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicInteger; import javax.annotation.Nullable; /** * A SkyFunction for {@link PackageValue}s. */ public class PackageFunction implements SkyFunction { private final PackageFactory packageFactory; private final CachingPackageLocator packageLocator; private final Cache> packageFunctionCache; private final Cache> astCache; private final AtomicBoolean showLoadingProgress; private final AtomicInteger numPackagesLoaded; private final Profiler profiler = Profiler.instance(); private final Label preludeLabel; // Not final only for testing. @Nullable private SkylarkImportLookupFunction skylarkImportLookupFunctionForInlining; static final PathFragment DEFAULTS_PACKAGE_NAME = new PathFragment("tools/defaults"); public PackageFunction( PackageFactory packageFactory, CachingPackageLocator pkgLocator, AtomicBoolean showLoadingProgress, Cache> packageFunctionCache, Cache> astCache, AtomicInteger numPackagesLoaded, @Nullable SkylarkImportLookupFunction skylarkImportLookupFunctionForInlining) { this.skylarkImportLookupFunctionForInlining = skylarkImportLookupFunctionForInlining; // Can be null in tests. this.preludeLabel = packageFactory == null ? null : packageFactory.getRuleClassProvider().getPreludeLabel(); this.packageFactory = packageFactory; this.packageLocator = pkgLocator; this.showLoadingProgress = showLoadingProgress; this.packageFunctionCache = packageFunctionCache; this.astCache = astCache; this.numPackagesLoaded = numPackagesLoaded; } public void setSkylarkImportLookupFunctionForInliningForTesting( SkylarkImportLookupFunction skylarkImportLookupFunctionForInlining) { this.skylarkImportLookupFunctionForInlining = skylarkImportLookupFunctionForInlining; } /** An entry in {@link PackageFunction}'s internal caches. */ public static class CacheEntryWithGlobDeps { private final T value; private final Set globDepKeys; @Nullable private final Globber legacyGlobber; private CacheEntryWithGlobDeps(T value, Set globDepKeys, @Nullable Globber legacyGlobber) { this.value = value; this.globDepKeys = globDepKeys; this.legacyGlobber = legacyGlobber; } } private static void maybeThrowFilesystemInconsistency(PackageIdentifier packageIdentifier, Exception skyframeException, boolean packageWasInError) throws InternalInconsistentFilesystemException { if (!packageWasInError) { throw new InternalInconsistentFilesystemException(packageIdentifier, "Encountered error '" + skyframeException.getMessage() + "' but didn't encounter it when doing the same thing " + "earlier in the build"); } } /** * Marks the given dependencies, and returns those already present. Ignores any exception * thrown while building the dependency, except for filesystem inconsistencies. * *

We need to mark dependencies implicitly used by the legacy package loading code, but we * don't care about any skyframe errors since the package knows whether it's in error or not. */ private static Pair, Boolean> getPackageLookupDepsAndPropagateInconsistentFilesystemExceptions( PackageIdentifier packageIdentifier, Iterable depKeys, Environment env, boolean packageWasInError) throws InternalInconsistentFilesystemException { Preconditions.checkState( Iterables.all(depKeys, SkyFunctions.isSkyFunction(SkyFunctions.PACKAGE_LOOKUP)), depKeys); boolean packageShouldBeInError = packageWasInError; ImmutableMap.Builder builder = ImmutableMap.builder(); for (Map.Entry> entry : env.getValuesOrThrow(depKeys, BuildFileNotFoundException.class, InconsistentFilesystemException.class, FileSymlinkException.class).entrySet()) { PathFragment pkgName = ((PackageIdentifier) entry.getKey().argument()).getPackageFragment(); try { PackageLookupValue value = (PackageLookupValue) entry.getValue().get(); if (value != null) { builder.put(pkgName, value); } } catch (BuildFileNotFoundException e) { maybeThrowFilesystemInconsistency(packageIdentifier, e, packageWasInError); } catch (InconsistentFilesystemException e) { throw new InternalInconsistentFilesystemException(packageIdentifier, e); } catch (FileSymlinkException e) { // Legacy doesn't detect symlink cycles. packageShouldBeInError = true; } } return Pair.of(builder.build(), packageShouldBeInError); } private static boolean markFileDepsAndPropagateInconsistentFilesystemExceptions( PackageIdentifier packageIdentifier, Iterable depKeys, Environment env, boolean packageWasInError) throws InternalInconsistentFilesystemException { Preconditions.checkState( Iterables.all(depKeys, SkyFunctions.isSkyFunction(SkyFunctions.FILE)), depKeys); boolean packageShouldBeInError = packageWasInError; for (Map.Entry> entry : env.getValuesOrThrow(depKeys, IOException.class, FileSymlinkException.class, InconsistentFilesystemException.class).entrySet()) { try { entry.getValue().get(); } catch (IOException e) { maybeThrowFilesystemInconsistency(packageIdentifier, e, packageWasInError); } catch (FileSymlinkException e) { // Legacy doesn't detect symlink cycles. packageShouldBeInError = true; } catch (InconsistentFilesystemException e) { throw new InternalInconsistentFilesystemException(packageIdentifier, e); } } return packageShouldBeInError; } /** * These deps have already been marked (see {@link SkyframeHybridGlobber}) but we need to properly * handle some errors that legacy package loading can't handle gracefully. */ private static boolean handleGlobDepsAndPropagateInconsistentFilesystemExceptions( PackageIdentifier packageIdentifier, Iterable depKeys, Environment env, boolean packageWasInError) throws InternalInconsistentFilesystemException { Preconditions.checkState( Iterables.all(depKeys, SkyFunctions.isSkyFunction(SkyFunctions.GLOB)), depKeys); boolean packageShouldBeInError = packageWasInError; for (Map.Entry> entry : env.getValuesOrThrow(depKeys, IOException.class, BuildFileNotFoundException.class, FileSymlinkException.class, InconsistentFilesystemException.class).entrySet()) { try { entry.getValue().get(); } catch (IOException | BuildFileNotFoundException e) { maybeThrowFilesystemInconsistency(packageIdentifier, e, packageWasInError); } catch (FileSymlinkException e) { // Legacy doesn't detect symlink cycles. packageShouldBeInError = true; } catch (InconsistentFilesystemException e) { throw new InternalInconsistentFilesystemException(packageIdentifier, e); } } return packageShouldBeInError; } /** * Marks dependencies implicitly used by legacy package loading code, after the fact. Note that * the given package might already be in error. * *

Any skyframe exceptions encountered here are ignored, as similar errors should have * already been encountered by legacy package loading (if not, then the filesystem is * inconsistent). */ private static boolean markDependenciesAndPropagateInconsistentFilesystemExceptions( Environment env, Set globDepKeys, Map subincludes, PackageIdentifier packageIdentifier, boolean containsErrors) throws InternalInconsistentFilesystemException { boolean packageShouldBeInError = containsErrors; // TODO(bazel-team): This means that many packages will have to be preprocessed twice. Ouch! // We need a better continuation mechanism to avoid repeating work. [skyframe-loading] // TODO(bazel-team): It would be preferable to perform I/O from the package preprocessor via // Skyframe rather than add (potentially incomplete) dependencies after the fact. // [skyframe-loading] Set subincludePackageLookupDepKeys = Sets.newHashSet(); for (Label label : subincludes.keySet()) { // Declare a dependency on the package lookup for the package giving access to the label. subincludePackageLookupDepKeys.add(PackageLookupValue.key(label.getPackageIdentifier())); } Pair, Boolean> subincludePackageLookupResult = getPackageLookupDepsAndPropagateInconsistentFilesystemExceptions( packageIdentifier, subincludePackageLookupDepKeys, env, containsErrors); Map subincludePackageLookupDeps = subincludePackageLookupResult.getFirst(); packageShouldBeInError |= subincludePackageLookupResult.getSecond(); List subincludeFileDepKeys = Lists.newArrayList(); for (Entry subincludeEntry : subincludes.entrySet()) { // Ideally, we would have a direct dependency on the target with the given label, but then // subincluding a file from the same package will cause a dependency cycle, since targets // depend on their containing packages. Label label = subincludeEntry.getKey(); PackageLookupValue subincludePackageLookupValue = subincludePackageLookupDeps.get(label.getPackageFragment()); if (subincludePackageLookupValue != null) { // Declare a dependency on the actual file that was subincluded. Path subincludeFilePath = subincludeEntry.getValue(); if (subincludeFilePath != null && !subincludePackageLookupValue.packageExists()) { // Legacy blaze puts a non-null path when only when the package does indeed exist. throw new InternalInconsistentFilesystemException( packageIdentifier, String.format( "Unexpected package in %s. Was it modified during the build?", subincludeFilePath)); } if (subincludePackageLookupValue.packageExists()) { // Sanity check for consistency of Skyframe and legacy blaze. Path subincludeFilePathSkyframe = subincludePackageLookupValue.getRoot().getRelative(label.toPathFragment()); if (subincludeFilePath != null && !subincludeFilePathSkyframe.equals(subincludeFilePath)) { throw new InternalInconsistentFilesystemException( packageIdentifier, String.format( "Inconsistent package location for %s: '%s' vs '%s'. " + "Was the source tree modified during the build?", label.getPackageFragment(), subincludeFilePathSkyframe, subincludeFilePath)); } // The actual file may be under a different package root than the package being // constructed. SkyKey subincludeSkyKey = FileValue.key( RootedPath.toRootedPath( subincludePackageLookupValue.getRoot(), label.getPackageFragment().getRelative(label.getName()))); subincludeFileDepKeys.add(subincludeSkyKey); } } } packageShouldBeInError |= markFileDepsAndPropagateInconsistentFilesystemExceptions( packageIdentifier, subincludeFileDepKeys, env, containsErrors); packageShouldBeInError |= handleGlobDepsAndPropagateInconsistentFilesystemExceptions( packageIdentifier, globDepKeys, env, containsErrors); return packageShouldBeInError; } /** * Adds a dependency on the WORKSPACE file, representing it as a special type of package. * @throws PackageFunctionException if there is an error computing the workspace file or adding * its rules to the //external package. */ private SkyValue getExternalPackage(Environment env, Path packageLookupPath) throws PackageFunctionException { RootedPath workspacePath = RootedPath.toRootedPath( packageLookupPath, new PathFragment("WORKSPACE")); SkyKey workspaceKey = ExternalPackageFunction.key(workspacePath); PackageValue workspace = null; try { workspace = (PackageValue) env.getValueOrThrow(workspaceKey, IOException.class, FileSymlinkException.class, InconsistentFilesystemException.class, EvalException.class, SkylarkImportFailedException.class); } catch (IOException | FileSymlinkException | InconsistentFilesystemException | EvalException | SkylarkImportFailedException e) { throw new PackageFunctionException(new BadWorkspaceFileException(e.getMessage()), Transience.PERSISTENT); } if (workspace == null) { return null; } Package pkg = workspace.getPackage(); Event.replayEventsOn(env.getListener(), pkg.getEvents()); return new PackageValue(pkg); } @Override public SkyValue compute(SkyKey key, Environment env) throws PackageFunctionException, InterruptedException { PackageIdentifier packageId = (PackageIdentifier) key.argument(); PathFragment packageNameFragment = packageId.getPackageFragment(); SkyKey packageLookupKey = PackageLookupValue.key(packageId); PackageLookupValue packageLookupValue; try { packageLookupValue = (PackageLookupValue) env.getValueOrThrow(packageLookupKey, BuildFileNotFoundException.class, InconsistentFilesystemException.class); } catch (BuildFileNotFoundException e) { throw new PackageFunctionException(e, Transience.PERSISTENT); } catch (InconsistentFilesystemException e) { // This error is not transient from the perspective of the PackageFunction. throw new PackageFunctionException( new InternalInconsistentFilesystemException(packageId, e), Transience.PERSISTENT); } if (packageLookupValue == null) { return null; } if (!packageLookupValue.packageExists()) { switch (packageLookupValue.getErrorReason()) { case NO_BUILD_FILE: case DELETED_PACKAGE: throw new PackageFunctionException(new BuildFileNotFoundException(packageId, packageLookupValue.getErrorMsg()), Transience.PERSISTENT); case INVALID_PACKAGE_NAME: throw new PackageFunctionException(new InvalidPackageNameException(packageId, packageLookupValue.getErrorMsg()), Transience.PERSISTENT); default: // We should never get here. throw new IllegalStateException(); } } if (packageId.equals(Label.EXTERNAL_PACKAGE_IDENTIFIER)) { return getExternalPackage(env, packageLookupValue.getRoot()); } SkyKey externalPackageKey = PackageValue.key(Label.EXTERNAL_PACKAGE_IDENTIFIER); PackageValue externalPackage = (PackageValue) env.getValue(externalPackageKey); if (externalPackage == null) { return null; } Package externalPkg = externalPackage.getPackage(); if (externalPkg.containsErrors()) { throw new PackageFunctionException( new BuildFileContainsErrorsException(Label.EXTERNAL_PACKAGE_IDENTIFIER), Transience.PERSISTENT); } PathFragment buildFileFragment = packageNameFragment.getChild("BUILD"); RootedPath buildFileRootedPath = RootedPath.toRootedPath(packageLookupValue.getRoot(), buildFileFragment); FileValue buildFileValue = null; Path buildFilePath = buildFileRootedPath.asPath(); String replacementContents = null; if (!isDefaultsPackage(packageId)) { buildFileValue = getBuildFileValue(env, buildFileRootedPath); if (buildFileValue == null) { return null; } } else { replacementContents = PrecomputedValue.DEFAULTS_PACKAGE_CONTENTS.get(env); if (replacementContents == null) { return null; } } RuleVisibility defaultVisibility = PrecomputedValue.DEFAULT_VISIBILITY.get(env); if (defaultVisibility == null) { return null; } SkyKey astLookupKey = ASTFileLookupValue.key(preludeLabel); ASTFileLookupValue astLookupValue = null; try { astLookupValue = (ASTFileLookupValue) env.getValueOrThrow(astLookupKey, ErrorReadingSkylarkExtensionException.class, InconsistentFilesystemException.class); } catch (ErrorReadingSkylarkExtensionException | InconsistentFilesystemException e) { throw new PackageFunctionException( new BadPreludeFileException(packageId, e.getMessage()), Transience.PERSISTENT); } if (astLookupValue == null) { return null; } // The prelude file doesn't have to exist. If not, we substitute an empty statement list. List preludeStatements = astLookupValue.lookupSuccessful() ? astLookupValue.getAST().getStatements() : ImmutableList.of(); CacheEntryWithGlobDeps packageBuilderAndGlobDeps = loadPackage( externalPkg, replacementContents, packageId, buildFilePath, buildFileValue, defaultVisibility, preludeStatements, packageLookupValue.getRoot(), env); if (packageBuilderAndGlobDeps == null) { return null; } Package.LegacyBuilder legacyPkgBuilder = packageBuilderAndGlobDeps.value; legacyPkgBuilder.buildPartial(); try { // Since the Skyframe dependencies we request below in // markDependenciesAndPropagateInconsistentFilesystemExceptions are requested independently of // the ones requested here in // handleLabelsCrossingSubpackagesAndPropagateInconsistentFilesystemExceptions, we don't // bother checking for missing values and instead piggyback on the env.missingValues() call // for the former. This avoids a Skyframe restart. handleLabelsCrossingSubpackagesAndPropagateInconsistentFilesystemExceptions( packageLookupValue.getRoot(), packageId, legacyPkgBuilder, env); } catch (InternalInconsistentFilesystemException e) { packageFunctionCache.invalidate(packageId); throw new PackageFunctionException(e, e.isTransient() ? Transience.TRANSIENT : Transience.PERSISTENT); } Set globKeys = packageBuilderAndGlobDeps.globDepKeys; Map subincludes = legacyPkgBuilder.getSubincludes(); boolean packageShouldBeConsideredInError; try { packageShouldBeConsideredInError = markDependenciesAndPropagateInconsistentFilesystemExceptions( env, globKeys, subincludes, packageId, legacyPkgBuilder.containsErrors()); } catch (InternalInconsistentFilesystemException e) { packageFunctionCache.invalidate(packageId); throw new PackageFunctionException(e, e.isTransient() ? Transience.TRANSIENT : Transience.PERSISTENT); } if (env.valuesMissing()) { return null; } Event.replayEventsOn(env.getListener(), legacyPkgBuilder.getEvents()); if (packageShouldBeConsideredInError) { legacyPkgBuilder.setContainsErrors(); } Package pkg = legacyPkgBuilder.finishBuild(); // We know this SkyFunction will not be called again, so we can remove the cache entry. packageFunctionCache.invalidate(packageId); return new PackageValue(pkg); } private FileValue getBuildFileValue(Environment env, RootedPath buildFileRootedPath) { FileValue buildFileValue; try { buildFileValue = (FileValue) env.getValueOrThrow(FileValue.key(buildFileRootedPath), IOException.class, FileSymlinkException.class, InconsistentFilesystemException.class); } catch (IOException | FileSymlinkException | InconsistentFilesystemException e) { throw new IllegalStateException("Package lookup succeeded but encountered error when " + "getting FileValue for BUILD file directly.", e); } if (buildFileValue == null) { return null; } Preconditions.checkState(buildFileValue.exists(), "Package lookup succeeded but BUILD file doesn't exist"); return buildFileValue; } @Nullable private SkylarkImportResult discoverSkylarkImports( Path buildFilePath, PackageIdentifier packageId, AstAfterPreprocessing astAfterPreprocessing, Environment env) throws PackageFunctionException, InterruptedException { SkylarkImportResult importResult; if (astAfterPreprocessing.containsAstParsingErrors) { importResult = new SkylarkImportResult( ImmutableMap.of(), ImmutableList.

There are three advantages to this hybrid approach over the more obvious approach of solely * using a {@link PackageFactory.LegacyGlobber}: *

    *
  • We trivially have the proper Skyframe {@link GlobValue} deps, whereas we would need to * request them after-the-fact if we solely used a {@link PackageFactory.LegacyGlobber}. *
  • We don't need to re-evaluate globs whose expression hasn't changed (e.g. in the common case * of a BUILD file edit that doesn't change a glob expression), whereas legacy package loading * with a {@link PackageFactory.LegacyGlobber} would naively re-evaluate globs when re-evaluating * the BUILD file. *
  • We don't need to re-evaluate invalidated globs *twice* (the single re-evaluation via our * GlobValue deps is sufficient and optimal). See above for why the second evaluation would * happen. *
*/ private static class SkyframeHybridGlobber implements Globber { private final PackageIdentifier packageId; private final Path packageRoot; private final Environment env; private final Globber delegate; private final Set globDepsRequested = Sets.newConcurrentHashSet(); private SkyframeHybridGlobber(PackageIdentifier packageId, Path packageRoot, Environment env, Globber delegate) { this.packageId = packageId; this.packageRoot = packageRoot; this.env = env; this.delegate = delegate; } private Set getGlobDepsRequested() { return ImmutableSet.copyOf(globDepsRequested); } private SkyKey getGlobKey(String pattern, boolean excludeDirs) throws BadGlobException { try { return GlobValue.key(packageId, packageRoot, pattern, excludeDirs, PathFragment.EMPTY_FRAGMENT); } catch (InvalidGlobPatternException e) { throw new BadGlobException(e.getMessage()); } } @Override public Token runAsync(List includes, List excludes, boolean excludeDirs) throws BadGlobException { List globKeys = new ArrayList<>(includes.size() + excludes.size()); LinkedHashSet includesKeys = Sets.newLinkedHashSetWithExpectedSize(includes.size()); LinkedHashSet excludesKeys = Sets.newLinkedHashSetWithExpectedSize(excludes.size()); Map globKeyToIncludeStringMap = Maps.newHashMapWithExpectedSize(includes.size()); Map globKeyToExcludeStringMap = Maps.newHashMapWithExpectedSize(excludes.size()); for (String pattern : includes) { SkyKey globKey = getGlobKey(pattern, excludeDirs); globKeys.add(globKey); includesKeys.add(globKey); globKeyToIncludeStringMap.put(globKey, pattern); } for (String pattern : excludes) { SkyKey globKey = getGlobKey(pattern, excludeDirs); globKeys.add(globKey); excludesKeys.add(globKey); globKeyToExcludeStringMap.put(globKey, pattern); } globDepsRequested.addAll(globKeys); Map> globValueMap = env.getValuesOrThrow(globKeys, IOException.class, BuildFileNotFoundException.class, FileSymlinkCycleException.class, InconsistentFilesystemException.class); // For each missing glob, evaluate it asychronously via the delegate. // // TODO(bazel-team): Consider not delegating missing globs during glob prefetching - a // single skyframe restart after the prefetch step is probably tolerable. Collection missingKeys = getMissingKeys(globKeys, globValueMap); List includesToDelegate = new ArrayList<>(missingKeys.size()); List excludesToDelegate = new ArrayList<>(missingKeys.size()); for (SkyKey missingKey : missingKeys) { String missingIncludePattern = globKeyToIncludeStringMap.get(missingKey); if (missingIncludePattern != null) { includesToDelegate.add(missingIncludePattern); includesKeys.remove(missingKey); } String missingExcludePattern = globKeyToExcludeStringMap.get(missingKey); if (missingExcludePattern != null) { excludesToDelegate.add(missingExcludePattern); excludesKeys.remove(missingKey); } } Token delegateIncludesToken = delegate.runAsync(includesToDelegate, ImmutableList.of(), excludeDirs); // See the HybridToken class-comment for why we pass excludesToDelegate as the includes // parameter here. Token delegateExcludesToken = delegate.runAsync(excludesToDelegate, ImmutableList.of(), excludeDirs); return new HybridToken(globValueMap, includesKeys, excludesKeys, delegateIncludesToken, delegateExcludesToken); } private Collection getMissingKeys(Collection globKeys, Map> globValueMap) { List missingKeys = new ArrayList<>(globKeys.size()); for (SkyKey globKey : globKeys) { ValueOrException4 valueOrException = globValueMap.get(globKey); if (valueOrException == null) { missingKeys.add(globKey); } try { if (valueOrException.get() == null) { missingKeys.add(globKey); } } catch (IOException | BuildFileNotFoundException | FileSymlinkCycleException | InconsistentFilesystemException doesntMatter) { continue; } } return missingKeys; } @Override public List fetch(Token token) throws IOException, InterruptedException { HybridToken hybridToken = (HybridToken) token; return hybridToken.resolve(delegate); } @Override public void onInterrupt() { delegate.onInterrupt(); } @Override public void onCompletion() { delegate.onCompletion(); } /** * A {@link Globber.Token} that encapsulates the result of a single {@link Globber#runAsync} * call via the fetching of some globs from skyframe, and some other globs via a * {@link PackageFactory.LegacyGlobber}. We take care to properly handle 'includes' vs * 'excludes'. * *

That is, we evaluate {@code glob(includes, excludes)} by partitioning {@code includes} and * {@code excludes}. * *

     * {@code
     * includes = includes_sky U includes_leg
     * excludes = excludes_sky U excludes_leg
     * }
     * 
* *

and then noting * *

     * {@code
     * glob(includes, excludes) =
     *     (glob(includes_sky, []) U glob(includes_leg, []))
     *   - (glob(excludes_sky, []) U glob(excludes_leg, []))
     * }
     * 
* *

Importantly, we pass excludes=[] in all cases; otherwise we'd be incorrectly not * subtracting excluded glob matches from the overall list of matches. In other words, we * implement the subtractive nature of excludes ourselves in {@link #resolve}. */ private static class HybridToken extends Globber.Token { // The result of the Skyframe lookup for all the needed glob patterns. private final Map> globValueMap; // The skyframe keys corresponding to the 'includes' patterns fetched from Skyframe // (this is includes_sky above). private final Iterable includesGlobKeys; // The skyframe keys corresponding to the 'excludes' patterns fetched from Skyframe // (this is excludes_sky above). private final Iterable excludesGlobKeys; // A token for computing includes_leg. private final Token delegateIncludesToken; // A token for computing excludes_leg. private final Token delegateExcludesToken; private HybridToken(Map> globValueMap, Iterable includesGlobKeys, Iterable excludesGlobKeys, Token delegateIncludesToken, Token delegateExcludesToken) { this.globValueMap = globValueMap; this.includesGlobKeys = includesGlobKeys; this.excludesGlobKeys = excludesGlobKeys; this.delegateIncludesToken = delegateIncludesToken; this.delegateExcludesToken = delegateExcludesToken; } private List resolve(Globber delegate) throws IOException, InterruptedException { LinkedHashSet matches = Sets.newLinkedHashSet(); for (SkyKey includeGlobKey : includesGlobKeys) { // TODO(bazel-team): NestedSet expansion here is suboptimal. for (PathFragment match : getGlobMatches(includeGlobKey, globValueMap)) { matches.add(match.getPathString()); } } matches.addAll(delegate.fetch(delegateIncludesToken)); for (SkyKey excludeGlobKey : excludesGlobKeys) { for (PathFragment match : getGlobMatches(excludeGlobKey, globValueMap)) { matches.remove(match.getPathString()); } } for (String delegateExcludeMatch : delegate.fetch(delegateExcludesToken)) { matches.remove(delegateExcludeMatch); } return Lists.newArrayList(matches); } private Iterable getGlobMatches(SkyKey globKey, Map> globValueMap) throws IOException { ValueOrException4 valueOrException = Preconditions.checkNotNull(globValueMap.get(globKey), "%s should not be missing", globKey); try { // TODO(bazel-team): NestedSet expansion here is suboptimal. return Preconditions.checkNotNull((GlobValue) valueOrException.get(), "%s should not be missing", globKey).getMatches(); } catch (BuildFileNotFoundException | FileSymlinkCycleException | InconsistentFilesystemException e) { // Legacy package loading is only able to handle an IOException, so a rethrow here is the // best we can do. But after legacy package loading, PackageFunction will go through all // the skyframe deps and properly handle InconsistentFilesystemExceptions. throw new IOException(e.getMessage()); } } } } /** * Constructs a {@link Package} object for the given package using legacy package loading. * Note that the returned package may be in error. * *

May return null if the computation has to be restarted. * *

Exactly one of {@code replacementContents} and {@code buildFileValue} will be * non-{@code null}. The former indicates that we have a faux BUILD file with the given contents * and the latter indicates that we have a legitimate BUILD file and should actually do * preprocessing. */ @Nullable private CacheEntryWithGlobDeps loadPackage( Package externalPkg, @Nullable String replacementContents, PackageIdentifier packageId, Path buildFilePath, @Nullable FileValue buildFileValue, RuleVisibility defaultVisibility, List preludeStatements, Path packageRoot, Environment env) throws InterruptedException, PackageFunctionException { CacheEntryWithGlobDeps packageFunctionCacheEntry = packageFunctionCache.getIfPresent(packageId); if (packageFunctionCacheEntry == null) { profiler.startTask(ProfilerTask.CREATE_PACKAGE, packageId.toString()); try { CacheEntryWithGlobDeps astCacheEntry = astCache.getIfPresent(packageId); if (astCacheEntry == null) { if (showLoadingProgress.get()) { env.getListener().handle(Event.progress("Loading package: " + packageId)); } Globber legacyGlobber = packageFactory.createLegacyGlobber( buildFilePath.getParentDirectory(), packageId, packageLocator); SkyframeHybridGlobber skyframeGlobber = new SkyframeHybridGlobber(packageId, packageRoot, env, legacyGlobber); Preprocessor.Result preprocessingResult; if (replacementContents == null) { Preconditions.checkNotNull(buildFileValue, packageId); byte[] buildFileBytes; try { buildFileBytes = buildFileValue.isSpecialFile() ? FileSystemUtils.readContent(buildFilePath) : FileSystemUtils.readWithKnownFileSize(buildFilePath, buildFileValue.getSize()); } catch (IOException e) { // Note that we did this work, so we should conservatively report this error as // transient. throw new PackageFunctionException(new BuildFileContainsErrorsException( packageId, e.getMessage()), Transience.TRANSIENT); } try { preprocessingResult = packageFactory.preprocess(buildFilePath, packageId, buildFileBytes, skyframeGlobber); } catch (IOException e) { throw new PackageFunctionException( new BuildFileContainsErrorsException( packageId, "preprocessing failed" + e.getMessage(), e), Transience.TRANSIENT); } } else { ParserInputSource replacementSource = ParserInputSource.create(replacementContents, buildFilePath.asFragment()); preprocessingResult = Preprocessor.Result.noPreprocessing(replacementSource); } StoredEventHandler astParsingEventHandler = new StoredEventHandler(); BuildFileAST ast = PackageFactory.parseBuildFile(packageId, preprocessingResult.result, preludeStatements, astParsingEventHandler); // If no globs were fetched during preprocessing, then there's no need to reuse the // legacy globber instance during BUILD file evaluation since the performance argument // below does not apply. Set globDepsRequested = skyframeGlobber.getGlobDepsRequested(); Globber legacyGlobberToStore = globDepsRequested.isEmpty() ? null : legacyGlobber; astCacheEntry = new CacheEntryWithGlobDeps<>( new AstAfterPreprocessing(preprocessingResult, ast, astParsingEventHandler), globDepsRequested, legacyGlobberToStore); astCache.put(packageId, astCacheEntry); } AstAfterPreprocessing astAfterPreprocessing = astCacheEntry.value; Set globDepsRequestedDuringPreprocessing = astCacheEntry.globDepKeys; SkylarkImportResult importResult; try { importResult = discoverSkylarkImports( buildFilePath, packageId, astAfterPreprocessing, env); } catch (PackageFunctionException | InterruptedException e) { astCache.invalidate(packageId); throw e; } if (importResult == null) { return null; } astCache.invalidate(packageId); // If a legacy globber was used to evaluate globs during preprocessing, it's important that // we reuse that globber during BUILD file evaluation for performance, in the case that // globs were fetched lazily during preprocessing. See Preprocessor.Factory#considersGlobs. Globber legacyGlobber = astCacheEntry.legacyGlobber != null ? astCacheEntry.legacyGlobber : packageFactory.createLegacyGlobber( buildFilePath.getParentDirectory(), packageId, packageLocator); SkyframeHybridGlobber skyframeGlobber = new SkyframeHybridGlobber(packageId, packageRoot, env, legacyGlobber); Package.LegacyBuilder pkgBuilder = packageFactory.createPackageFromPreprocessingAst( externalPkg, packageId, buildFilePath, astAfterPreprocessing, importResult.importMap, importResult.fileDependencies, defaultVisibility, skyframeGlobber); Set globDepsRequested = ImmutableSet.builder() .addAll(globDepsRequestedDuringPreprocessing) .addAll(skyframeGlobber.getGlobDepsRequested()) .build(); packageFunctionCacheEntry = new CacheEntryWithGlobDeps<>(pkgBuilder, globDepsRequested, null); numPackagesLoaded.incrementAndGet(); packageFunctionCache.put(packageId, packageFunctionCacheEntry); } finally { profiler.completeTask(ProfilerTask.CREATE_PACKAGE); } } return packageFunctionCacheEntry; } private static class InternalInconsistentFilesystemException extends NoSuchPackageException { private boolean isTransient; /** * Used to represent a filesystem inconsistency discovered outside the * {@link PackageFunction}. */ public InternalInconsistentFilesystemException(PackageIdentifier packageIdentifier, InconsistentFilesystemException e) { super(packageIdentifier, e.getMessage(), e); // This is not a transient error from the perspective of the PackageFunction. this.isTransient = false; } /** Used to represent a filesystem inconsistency discovered by the {@link PackageFunction}. */ public InternalInconsistentFilesystemException(PackageIdentifier packageIdentifier, String inconsistencyMessage) { this(packageIdentifier, new InconsistentFilesystemException(inconsistencyMessage)); this.isTransient = true; } public boolean isTransient() { return isTransient; } } private static class BadWorkspaceFileException extends NoSuchPackageException { private BadWorkspaceFileException(String message) { super( Label.EXTERNAL_PACKAGE_IDENTIFIER, "Error encountered while dealing with the WORKSPACE file: " + message); } } private static class BadPreludeFileException extends NoSuchPackageException { private BadPreludeFileException(PackageIdentifier packageIdentifier, String message) { super(packageIdentifier, "Error encountered while reading the prelude file: " + message); } } /** * Used to declare all the exception types that can be wrapped in the exception thrown by * {@link PackageFunction#compute}. */ static class PackageFunctionException extends SkyFunctionException { public PackageFunctionException(NoSuchPackageException e, Transience transience) { super(e, transience); } } /** A simple value class to store the result of the Skylark imports.*/ static final class SkylarkImportResult { final Map importMap; final ImmutableList