From 7ca9e859597d99c899523603fb9a399766401793 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Sat, 23 Dec 2017 08:47:42 +0100 Subject: grpc rules: Make Skylark rule forwards compatible This fixes: [f for dep in ctx.attr.srcs for f in dep.proto.transitive_imports] type 'depset' is not iterable. Use the `to_list()` method to get a list. Change-Id: I72b8c1c788a5c193af4d4293f0cf81ba4f0da1c6 --- third_party/grpc/build_defs.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'third_party/grpc') diff --git a/third_party/grpc/build_defs.bzl b/third_party/grpc/build_defs.bzl index 521ea43c30..db9ed0d40e 100644 --- a/third_party/grpc/build_defs.bzl +++ b/third_party/grpc/build_defs.bzl @@ -16,7 +16,7 @@ def _gensource_impl(ctx): + "same package as consuming rule").format(ctx.label, s.label)) srcdotjar = ctx.new_file(ctx.label.name + ".jar") srcs = [f for dep in ctx.attr.srcs for f in dep.proto.direct_sources] - includes = [f for dep in ctx.attr.srcs for f in dep.proto.transitive_imports] + includes = [f for dep in ctx.attr.srcs for f in dep.proto.transitive_imports.to_list()] ctx.action( command = " ".join([ -- cgit v1.2.3