From fab4b888b4d0739e9269ecc0a6545e35fa185f66 Mon Sep 17 00:00:00 2001 From: Alex Humesky Date: Wed, 11 Nov 2015 20:26:45 +0000 Subject: Deprecation warnings are no longer printed for flags specified using their old name. -- MOS_MIGRATED_REVID=107611961 --- .../com/google/devtools/common/options/OptionsParserImpl.java | 10 ---------- .../com/google/devtools/common/options/OptionsParserTest.java | 2 -- 2 files changed, 12 deletions(-) (limited to 'src') diff --git a/src/main/java/com/google/devtools/common/options/OptionsParserImpl.java b/src/main/java/com/google/devtools/common/options/OptionsParserImpl.java index e2cc6b8ce2..5f90594f1a 100644 --- a/src/main/java/com/google/devtools/common/options/OptionsParserImpl.java +++ b/src/main/java/com/google/devtools/common/options/OptionsParserImpl.java @@ -587,16 +587,6 @@ class OptionsParserImpl { value = "0"; } } - - // Add a deprecation warning if the old name for the flag is used. - if (field != null) { - Option option = field.getAnnotation(Option.class); - String oldName = option.oldName(); - if (name.equals(oldName)) { - addDeprecationWarning(oldName, "Use --" + option.name() + " instead"); - } - } - } else { throw new OptionsParsingException("Invalid options syntax: " + arg, arg); } diff --git a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java index 396369467e..0787a398cc 100644 --- a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java +++ b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java @@ -1038,8 +1038,6 @@ public class OptionsParserTest { parser.parse("--old_name=foo"); OldNameExample result = parser.getOptions(OldNameExample.class); assertEquals("foo", result.flag); - assertThat(parser.getWarnings()).contains( - "Option 'old_name' is deprecated: Use --new_name instead"); // Should also work by its new name. parser = newOptionsParser(OldNameExample.class); -- cgit v1.2.3