From c63b90f8828cf5c5c17d028d2e1a41371bf11c24 Mon Sep 17 00:00:00 2001 From: David Chen Date: Thu, 28 Jan 2016 12:31:29 +0000 Subject: Remove unused ${SYNOPSIS} variable from Bazel native rule inline documentation. This variable is no longer used because the docgen template directly calls RuleDocumentationAttribte.getSynopsis() instead of using the SYNOPSIS variable, and RuleDocumentationAttribute.getHtmlDocumentation() resolves the SYNOPSIS variable to the empty string. -- MOS_MIGRATED_REVID=113249993 --- .../lib/analysis/config/ConfigRuleClasses.java | 1 - .../lib/analysis/constraints/EnvironmentRule.java | 1 - .../rules/common/BazelActionListenerRule.java | 2 -- .../bazel/rules/common/BazelExtraActionRule.java | 4 --- .../lib/bazel/rules/common/BazelFilegroupRule.java | 3 -- .../lib/bazel/rules/common/BazelTestSuiteRule.java | 2 -- .../lib/bazel/rules/cpp/BazelCppRuleClasses.java | 15 ---------- .../lib/bazel/rules/genrule/BazelGenRuleRule.java | 8 ----- .../lib/bazel/rules/java/BazelJavaImportRule.java | 3 -- .../lib/bazel/rules/java/BazelJavaLibraryRule.java | 5 ---- .../lib/bazel/rules/java/BazelJavaPluginRule.java | 1 - .../lib/bazel/rules/java/BazelJavaRuleClasses.java | 14 --------- .../lib/bazel/rules/java/BazelJavaTestRule.java | 1 - .../bazel/rules/objc/BazelJ2ObjcLibraryRule.java | 1 - .../lib/bazel/rules/python/BazelPyLibraryRule.java | 3 -- .../lib/bazel/rules/python/BazelPyRuleClasses.java | 7 ----- .../lib/bazel/rules/python/BazelPyTestRule.java | 1 - .../lib/bazel/rules/sh/BazelShLibraryRule.java | 1 - .../lib/bazel/rules/sh/BazelShRuleClasses.java | 2 -- .../bazel/rules/workspace/GitRepositoryRule.java | 4 --- .../lib/bazel/rules/workspace/HttpArchiveRule.java | 4 --- .../lib/bazel/rules/workspace/HttpFileRule.java | 3 -- .../lib/bazel/rules/workspace/HttpJarRule.java | 2 -- .../lib/bazel/rules/workspace/MavenJarRule.java | 4 --- .../lib/bazel/rules/workspace/MavenServerRule.java | 2 -- .../rules/workspace/NewGitRepositoryRule.java | 5 ---- .../bazel/rules/workspace/NewHttpArchiveRule.java | 5 ---- .../lib/rules/android/AndroidBinaryOnlyRule.java | 7 ----- .../lib/rules/android/AndroidLibraryBaseRule.java | 7 ----- .../lib/rules/android/AndroidRuleClasses.java | 20 ------------- .../build/lib/rules/apple/XcodeConfigRule.java | 3 -- .../build/lib/rules/apple/XcodeVersionRule.java | 1 - .../build/lib/rules/genquery/GenQueryRule.java | 4 --- .../build/lib/rules/java/JavaImportBaseRule.java | 4 --- .../build/lib/rules/java/ProguardLibraryRule.java | 1 - .../build/lib/rules/objc/IosApplicationRule.java | 2 -- .../build/lib/rules/objc/IosDeviceRule.java | 2 -- .../build/lib/rules/objc/IosExtensionRule.java | 1 - .../build/lib/rules/objc/IosFrameworkRule.java | 2 -- .../devtools/build/lib/rules/objc/IosTestRule.java | 6 ---- .../lib/rules/objc/J2ObjcLibraryBaseRule.java | 1 - .../build/lib/rules/objc/ObjcBundleRule.java | 1 - .../build/lib/rules/objc/ObjcFrameworkRule.java | 1 - .../build/lib/rules/objc/ObjcImportRule.java | 1 - .../build/lib/rules/objc/ObjcProtoLibraryRule.java | 5 ---- .../build/lib/rules/objc/ObjcRuleClasses.java | 35 ---------------------- .../build/lib/rules/objc/ObjcXcodeprojRule.java | 1 - .../lib/rules/proto/BazelProtoLibraryRule.java | 2 -- .../build/lib/rules/repository/BindRule.java | 1 - .../lib/rules/repository/LocalRepositoryRule.java | 1 - .../rules/repository/NewLocalRepositoryRule.java | 2 -- 51 files changed, 215 deletions(-) (limited to 'src') diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java index cab80a37e0..47e1d64c41 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigRuleClasses.java @@ -112,7 +112,6 @@ public class ConfigRuleClasses { return builder /* The set of configuration values that match this rule (expressed as Blaze flags) - ${SYNOPSIS} (Dictionary mapping flags to expected values, both expressed as strings; mandatory) diff --git a/src/main/java/com/google/devtools/build/lib/analysis/constraints/EnvironmentRule.java b/src/main/java/com/google/devtools/build/lib/analysis/constraints/EnvironmentRule.java index 3bd6f42274..48a0182a25 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/constraints/EnvironmentRule.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/constraints/EnvironmentRule.java @@ -42,7 +42,6 @@ public class EnvironmentRule implements RuleDefinition { .nonconfigurable("low-level attribute, used in TargetUtils without configurations")) /* The set of environments this one is considered a valid "standin" for. - ${SYNOPSIS}

If rule A depends on rule B, A declares compatibility with environment :foo, and B declares compatibility with environment :bar, this is normally not diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelActionListenerRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelActionListenerRule.java index 2b198f5385..a7c9fa69b3 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelActionListenerRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelActionListenerRule.java @@ -34,7 +34,6 @@ public final class BazelActionListenerRule implements RuleDefinition { /* A list of action mnemonics this action_listener should listen for, e.g. [ "Javac" ]. - ${SYNOPSIS}

Mnemonics are not a public interface. There's no guarantee that the mnemonics and their actions don't change. @@ -44,7 +43,6 @@ public final class BazelActionListenerRule implements RuleDefinition { /* A list of extra_action targets this action_listener should add to the build graph. - ${SYNOPSIS} E.g. [ "//my/tools:analyzer" ]. */ .add(attr("extra_actions", LABEL_LIST).mandatory() diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelExtraActionRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelExtraActionRule.java index d4fc70b149..ea3ce53fa2 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelExtraActionRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/common/BazelExtraActionRule.java @@ -40,7 +40,6 @@ public final class BazelExtraActionRule implements RuleDefinition { return builder /* A list of tool dependencies for this rule. - ${SYNOPSIS}

See the definition of dependencies for more information. @@ -62,7 +61,6 @@ public final class BazelExtraActionRule implements RuleDefinition { .add(attr("tools", LABEL_LIST).cfg(HOST).allowedFileTypes().exec()) /* A list of templates for files generated by the extra_action command. - ${SYNOPSIS}

The template can use the following variables: