From 784ffc06ea463912eca747a3c3a796d649232650 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Wed, 23 Sep 2015 16:57:24 +0000 Subject: Remove LoadedPackageProvider.getLoadedPackage, which is unused. -- MOS_MIGRATED_REVID=103755120 --- .../devtools/build/lib/pkgcache/LoadedPackageProvider.java | 9 --------- .../devtools/build/lib/skyframe/SkyframePackageManager.java | 3 +-- 2 files changed, 1 insertion(+), 11 deletions(-) (limited to 'src') diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadedPackageProvider.java b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadedPackageProvider.java index 980d2b8fc2..337c5385dc 100644 --- a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadedPackageProvider.java +++ b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadedPackageProvider.java @@ -14,10 +14,8 @@ package com.google.devtools.build.lib.pkgcache; import com.google.devtools.build.lib.cmdline.Label; -import com.google.devtools.build.lib.cmdline.PackageIdentifier; import com.google.devtools.build.lib.packages.NoSuchPackageException; import com.google.devtools.build.lib.packages.NoSuchTargetException; -import com.google.devtools.build.lib.packages.Package; import com.google.devtools.build.lib.packages.Target; /** @@ -29,13 +27,6 @@ import com.google.devtools.build.lib.packages.Target; // TODO(bazel-team): Skyframe doesn't really implement this - can we remove it? public interface LoadedPackageProvider { - /** - * Returns a package if it was recently loaded, i.e., since the most recent cache sync. This - * throws an exception if the package was not loaded, even if it exists on disk. Returns the - * package even if it is in error. - */ - Package getLoadedPackage(PackageIdentifier packageIdentifier) throws NoSuchPackageException; - /** * Returns a target if it was recently loaded, i.e., since the most recent cache sync. This * throws an exception if the target was not loaded or not validated, even if it exists in the diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java index 568610b463..7c61ea3599 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java @@ -69,8 +69,7 @@ class SkyframePackageManager implements PackageManager { this.skyframeExecutor = skyframeExecutor; } - @Override - public Package getLoadedPackage(PackageIdentifier pkgIdentifier) throws NoSuchPackageException { + private Package getLoadedPackage(PackageIdentifier pkgIdentifier) throws NoSuchPackageException { return packageLoader.getLoadedPackage(pkgIdentifier); } -- cgit v1.2.3