From 681f36959d9e12a9599f1e3150f232a114333770 Mon Sep 17 00:00:00 2001 From: jcater Date: Fri, 27 Apr 2018 11:20:36 -0700 Subject: Ensure that all rules which (even very indirectly) call CppHelper.getToolchainFromPlatformConstraints declare that they require a cc toolchain. PiperOrigin-RevId: 194567799 --- .../google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java | 2 ++ .../google/devtools/build/lib/bazel/rules/python/BazelPyTestRule.java | 2 ++ 2 files changed, 4 insertions(+) (limited to 'src') diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java index 86f2a09601..baef8e2dd9 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java @@ -24,6 +24,7 @@ import com.google.devtools.build.lib.analysis.config.HostTransition; import com.google.devtools.build.lib.bazel.rules.python.BazelPyRuleClasses.PyBinaryBaseRule; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.packages.RuleClass; +import com.google.devtools.build.lib.rules.cpp.CppRuleClasses; import com.google.devtools.build.lib.rules.python.PyRuleClasses; import com.google.devtools.build.lib.rules.python.PythonConfiguration; @@ -52,6 +53,7 @@ public final class BazelPyBinaryRule implements RuleDefinition { .cfg(HostTransition.INSTANCE) .exec() .value(env.getToolsLabel("//tools/zip:zipper"))) + .addRequiredToolchains(CppRuleClasses.ccToolchainTypeAttribute(env)) .build(); } diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyTestRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyTestRule.java index 3ebc0ed7de..7f7a9bb6ee 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyTestRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyTestRule.java @@ -28,6 +28,7 @@ import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.packages.RuleClass; import com.google.devtools.build.lib.packages.RuleClass.Builder.RuleClassType; import com.google.devtools.build.lib.packages.TriState; +import com.google.devtools.build.lib.rules.cpp.CppRuleClasses; import com.google.devtools.build.lib.rules.python.PyRuleClasses; import com.google.devtools.build.lib.rules.python.PythonConfiguration; @@ -57,6 +58,7 @@ public final class BazelPyTestRule implements RuleDefinition { that the stamp argument is set to 0 by default for tests. */ .override(attr("stamp", TRISTATE).value(TriState.NO)) + .addRequiredToolchains(CppRuleClasses.ccToolchainTypeAttribute(env)) .build(); } -- cgit v1.2.3