From ef381e54b124a7bb71dcb883fdc999f3bd37d4ed Mon Sep 17 00:00:00 2001 From: Androbin Date: Thu, 14 Dec 2017 07:24:27 -0800 Subject: Shell code cleanup - Argument mixes string and array. Use * or separate argument. - Quote the grep pattern so the shell won't interpret it. - Use "${var:?}" to ensure this never expands to /* . - > is for string comparisons. Use -gt instead. - Quote the parameter to -name so the shell won't interpret it. Closes #4163. PiperOrigin-RevId: 179042046 --- src/tools/runfiles/runfiles_posix_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/tools/runfiles/runfiles_posix_test.sh') diff --git a/src/tools/runfiles/runfiles_posix_test.sh b/src/tools/runfiles/runfiles_posix_test.sh index 794c5fe9de..9a90661b26 100755 --- a/src/tools/runfiles/runfiles_posix_test.sh +++ b/src/tools/runfiles/runfiles_posix_test.sh @@ -19,7 +19,7 @@ set -eu function _log_base() { prefix=$1 shift - echo >&2 "${prefix}[$(basename "$0") $(date "+%H:%M:%S.%N (%z)")] $@" + echo >&2 "${prefix}[$(basename "$0") $(date "+%H:%M:%S.%N (%z)")] $*" } function log_fatal() { -- cgit v1.2.3