From 4022bac855a790b3a42fcb44c06f62dbbe078c5a Mon Sep 17 00:00:00 2001 From: Loo Rong Jie Date: Mon, 11 Jun 2018 02:04:52 -0700 Subject: Remove usage of COMPILER_MSVC in Bazel and ijar Convert most `COMPILER_MSVC` to `_WIN32` (as they apply to Windows platform, not MSVC compiler). Only `src/tools/singlejar/zip_headers.h` and `src/main/cpp/util/md5.h` actually need `_MSC_VER`. `COMPILER_MSVC` in `third_party/protobuf` are not removed. They can be fixed by updating dependency to newer version. /cc @meteorcloudy Closes #5350. Change-Id: Ibc131abfaf34a0cb2bd338549983ea9d28eaabfe PiperOrigin-RevId: 200019793 --- src/test/py/bazel/cc_import_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/test/py') diff --git a/src/test/py/bazel/cc_import_test.py b/src/test/py/bazel/cc_import_test.py index 1563957495..99ab086a28 100644 --- a/src/test/py/bazel/cc_import_test.py +++ b/src/test/py/bazel/cc_import_test.py @@ -79,7 +79,7 @@ class CcImportTest(test_base.TestBase): self.ScratchFile('lib/a.cc', [ '#include ', '', - '#ifdef COMPILER_MSVC', + '#ifdef _WIN32', ' #define DLLEXPORT __declspec(dllexport)', '#else', ' #define DLLEXPORT', -- cgit v1.2.3