From e96b0b88a5f9aa8cd816e3603b9179f040d79270 Mon Sep 17 00:00:00 2001 From: Florian Weikert Date: Fri, 25 Sep 2015 11:35:11 +0000 Subject: Skylark rules can no longer overwrite built-in attributes. -- MOS_MIGRATED_REVID=103931317 --- .../devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/test/java') diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java index c7ea6920b8..cce9b97a71 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java @@ -66,6 +66,13 @@ public class SkylarkRuleClassFunctionsTest extends SkylarkTestCase { ")"); } + public void testCannotOverrideBuiltInAttribute() throws Exception { + checkEvalError( + "There is already a built-in attribute 'tags' which cannot be overridden", + "def impl(ctx): return", + "r = rule(impl, attrs = {'tags': attr.string_list()})"); + } + public void testImplicitArgsAttribute() throws Exception { eval( "def _impl(ctx):", -- cgit v1.2.3