From 01f85c025aaf4b6c0f138f00515227a092dd05c2 Mon Sep 17 00:00:00 2001 From: Dmitry Lomov Date: Wed, 29 Jun 2016 06:37:50 +0000 Subject: For --aspects parameter, ignore top-level targets that are not rules. -- MOS_MIGRATED_REVID=126161513 --- .../devtools/build/lib/skylark/SkylarkAspectsTest.java | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'src/test/java') diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java index 8677771dd7..97368f8ed4 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java @@ -1031,6 +1031,22 @@ public class SkylarkAspectsTest extends AnalysisTestCase { } } + @Test + public void toplevelAspectOnFile() throws Exception { + scratch.file( + "test/aspect.bzl", + "def _impl(target, ctx):", + " print('This aspect does nothing')", + " return struct()", + "MyAspect = aspect(implementation=_impl)"); + scratch.file("test/BUILD", "exports_files(['file.txt'])"); + scratch.file("test/file.txt", ""); + AnalysisResult analysisResult = + update(ImmutableList.of("test/aspect.bzl%MyAspect"), "//test:file.txt"); + assertThat(analysisResult.hasError()).isFalse(); + assertThat(analysisResult.getAspects()).isEmpty(); + } + @RunWith(JUnit4.class) public static final class WithKeepGoing extends SkylarkAspectsTest { -- cgit v1.2.3