From f9efa42113c5bcf0aaadb73fbc3822b389cc5c96 Mon Sep 17 00:00:00 2001 From: ccalvarin Date: Wed, 19 Apr 2017 20:18:57 +0200 Subject: Don't hard remove --no_, give a warning first. PiperOrigin-RevId: 153610163 --- .../devtools/common/options/OptionsParserTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'src/test/java/com/google/devtools/common') diff --git a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java index 3d85315258..5b79dab689 100644 --- a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java +++ b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java @@ -1583,16 +1583,16 @@ public class OptionsParserTest { } @Test - public void testBooleanUnderscorePrefixError() { - try { - OptionsParser parser = newOptionsParser(ExampleBooleanFooOptions.class); - parser.parse("--no_foo"); + public void testBooleanUnderscorePrefixError() throws OptionsParsingException { + OptionsParser parser = newOptionsParser(ExampleBooleanFooOptions.class); + parser.parse("--no_foo"); + ExampleBooleanFooOptions result = parser.getOptions(ExampleBooleanFooOptions.class); + assertThat(result.foo).isFalse(); + List warning = parser.getWarnings(); + assertThat(warning).hasSize(1); + assertThat(warning.get(0)).contains("Option 'foo' is specified using the deprecated " + + "--no_ prefix. Use --no without the underscore instead"); - fail("--no_foo should fail to parse and provide a nice error message."); - } catch (OptionsParsingException e) { - assertThat(e.getMessage()).contains( - "'no_' prefixes are no longer accepted, --no is an accepted alternative."); - } } public static class WrapperOptionExample extends OptionsBase { -- cgit v1.2.3