From 09a900f48144e2dfac4acb54e981c09bb667ca62 Mon Sep 17 00:00:00 2001 From: Eric Fellheimer Date: Fri, 12 Jun 2015 15:34:48 +0000 Subject: Migrate C++ link action .params files to the Blaze-standard ParameterFileWriteAction. Performance changes: - output files of actions require an extra system call + incremental builds no longer require re-writing the .param file (typically) -- MOS_MIGRATED_REVID=95842983 --- .../google/devtools/build/lib/analysis/util/AnalysisTestUtil.java | 7 ++++++- .../google/devtools/build/lib/analysis/util/BuildViewTestCase.java | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) (limited to 'src/test/java/com/google/devtools/build/lib') diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java index cfe4acdc2b..5b47f0985e 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java @@ -60,6 +60,9 @@ import java.util.Map; import java.util.Set; import java.util.UUID; +/** + * Utilities for analysis phase tests. + */ public final class AnalysisTestUtil { /** @@ -293,7 +296,9 @@ public final class AnalysisTestUtil { } } - public static final AnalysisEnvironment STUB_ANALYSIS_ENVIRONMENT = new AnalysisEnvironment() { + public static final AnalysisEnvironment STUB_ANALYSIS_ENVIRONMENT = new StubAnalysisEnvironment(); + + public static class StubAnalysisEnvironment implements AnalysisEnvironment { @Override public void registerAction(Action... action) { } diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index 383037a341..cb6c0892dd 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -1314,7 +1314,10 @@ public abstract class BuildViewTestCase extends FoundationTestCase { StringUtil.joinEnglishList(ImmutableSet.copyOf(expected), "or", "'"), value); } - private class StubAnalysisEnvironment implements AnalysisEnvironment { + /** + * A stub analysis environment. + */ + protected class StubAnalysisEnvironment implements AnalysisEnvironment { @Override public void registerAction(Action... action) { -- cgit v1.2.3