From 5e606e6113902a5ddfe4f5e54fb72a0fd2f4c3e3 Mon Sep 17 00:00:00 2001 From: janakr Date: Wed, 19 Jul 2017 22:40:20 +0200 Subject: Reduce to one SequencedSkyframeExecutor#create method. The others were minor convenience methods that didn't (IMO) carry their weight. PiperOrigin-RevId: 162528716 --- .../devtools/build/lib/analysis/util/AnalysisTestCase.java | 9 +++++++-- .../devtools/build/lib/analysis/util/BuildViewTestCase.java | 9 +++++++-- .../devtools/build/lib/analysis/util/ConfigurationTestCase.java | 9 +++++++-- 3 files changed, 21 insertions(+), 6 deletions(-) (limited to 'src/test/java/com/google/devtools/build/lib/analysis') diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java index 04e8327cd8..b676cc576c 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java @@ -52,6 +52,7 @@ import com.google.devtools.build.lib.pkgcache.PackageCacheOptions; import com.google.devtools.build.lib.pkgcache.PackageManager; import com.google.devtools.build.lib.pkgcache.PathPackageLocator; import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction; +import com.google.devtools.build.lib.skyframe.BazelSkyframeExecutorConstants; import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey; import com.google.devtools.build.lib.skyframe.DiffAwareness; import com.google.devtools.build.lib.skyframe.PrecomputedValue; @@ -174,7 +175,7 @@ public abstract class AnalysisTestCase extends FoundationTestCase { .build(ruleClassProvider, scratch.getFileSystem()); BinTools binTools = BinTools.forUnitTesting(directories, analysisMock.getEmbeddedTools()); skyframeExecutor = - SequencedSkyframeExecutor.createForTesting( + SequencedSkyframeExecutor.create( pkgFactory, directories, binTools, @@ -185,7 +186,11 @@ public abstract class AnalysisTestCase extends FoundationTestCase { analysisMock.getSkyFunctions(), getPrecomputedValues(), ImmutableList.of(), - analysisMock.getProductName()); + PathFragment.EMPTY_FRAGMENT, + analysisMock.getProductName(), + BazelSkyframeExecutorConstants.CROSS_REPOSITORY_LABEL_VIOLATION_STRATEGY, + BazelSkyframeExecutorConstants.BUILD_FILES_BY_PRIORITY, + BazelSkyframeExecutorConstants.ACTION_ON_IO_EXCEPTION_READING_BUILD_FILE); PackageCacheOptions packageCacheOptions = Options.getDefaults(PackageCacheOptions.class); packageCacheOptions.showLoadingProgress = true; packageCacheOptions.globbingThreads = 3; diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index 9b46c818c3..20b779ccff 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -120,6 +120,7 @@ import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunctio import com.google.devtools.build.lib.rules.test.BaselineCoverageAction; import com.google.devtools.build.lib.rules.test.InstrumentedFilesProvider; import com.google.devtools.build.lib.skyframe.AspectValue; +import com.google.devtools.build.lib.skyframe.BazelSkyframeExecutorConstants; import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey; import com.google.devtools.build.lib.skyframe.DiffAwareness; import com.google.devtools.build.lib.skyframe.LegacyLoadingPhaseRunner; @@ -223,7 +224,7 @@ public abstract class BuildViewTestCase extends FoundationTestCase { .build(ruleClassProvider, scratch.getFileSystem()); tsgm = new TimestampGranularityMonitor(BlazeClock.instance()); skyframeExecutor = - SequencedSkyframeExecutor.createForTesting( + SequencedSkyframeExecutor.create( pkgFactory, directories, binTools, @@ -234,7 +235,11 @@ public abstract class BuildViewTestCase extends FoundationTestCase { analysisMock.getSkyFunctions(), getPrecomputedValues(), ImmutableList.of(), - analysisMock.getProductName()); + PathFragment.EMPTY_FRAGMENT, + analysisMock.getProductName(), + BazelSkyframeExecutorConstants.CROSS_REPOSITORY_LABEL_VIOLATION_STRATEGY, + BazelSkyframeExecutorConstants.BUILD_FILES_BY_PRIORITY, + BazelSkyframeExecutorConstants.ACTION_ON_IO_EXCEPTION_READING_BUILD_FILE); skyframeExecutor.injectExtraPrecomputedValues(extraPrecomputedValues); packageCacheOptions.defaultVisibility = ConstantRuleVisibility.PUBLIC; packageCacheOptions.showLoadingProgress = true; diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java index d87ac01d82..6970641bfe 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/ConfigurationTestCase.java @@ -36,6 +36,7 @@ import com.google.devtools.build.lib.packages.util.MockToolsConfig; import com.google.devtools.build.lib.pkgcache.PackageCacheOptions; import com.google.devtools.build.lib.pkgcache.PathPackageLocator; import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction; +import com.google.devtools.build.lib.skyframe.BazelSkyframeExecutorConstants; import com.google.devtools.build.lib.skyframe.DiffAwareness; import com.google.devtools.build.lib.skyframe.PrecomputedValue; import com.google.devtools.build.lib.skyframe.SequencedSkyframeExecutor; @@ -108,7 +109,7 @@ public abstract class ConfigurationTestCase extends FoundationTestCase { new AnalysisTestUtil.DummyWorkspaceStatusActionFactory(directories); skyframeExecutor = - SequencedSkyframeExecutor.createForTesting( + SequencedSkyframeExecutor.create( pkgFactory, directories, BinTools.forUnitTesting(directories, analysisMock.getEmbeddedTools()), @@ -119,7 +120,11 @@ public abstract class ConfigurationTestCase extends FoundationTestCase { analysisMock.getSkyFunctions(), ImmutableList.of(), ImmutableList.of(), - analysisMock.getProductName()); + PathFragment.EMPTY_FRAGMENT, + analysisMock.getProductName(), + BazelSkyframeExecutorConstants.CROSS_REPOSITORY_LABEL_VIOLATION_STRATEGY, + BazelSkyframeExecutorConstants.BUILD_FILES_BY_PRIORITY, + BazelSkyframeExecutorConstants.ACTION_ON_IO_EXCEPTION_READING_BUILD_FILE); skyframeExecutor.injectExtraPrecomputedValues(ImmutableList.of(PrecomputedValue.injected( RepositoryDelegatorFunction.REPOSITORY_OVERRIDES, ImmutableMap.of()))); -- cgit v1.2.3