From 351475627b9e94e5afdf472cbf465f49c433a25e Mon Sep 17 00:00:00 2001 From: Nathan Harmata Date: Tue, 5 Apr 2016 19:49:43 +0000 Subject: Make non-empty attribute checks happen during analysis of the target in question, rather than during loading of the target's package. This way a target's package won't be in error if e.g. an unrelated target has empty 'srcs'. -- MOS_MIGRATED_REVID=119079777 --- .../google/devtools/build/lib/analysis/util/BuildViewTestCase.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java') diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index 541356f75f..abb7a79772 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -1449,8 +1449,8 @@ public abstract class BuildViewTestCase extends FoundationTestCase { } protected String getErrorMsgNonEmptyList(String attrName, String ruleType, String ruleName) { - return "non empty attribute '" + attrName + "' in '" + ruleType - + "' rule '" + ruleName + "' has to have at least one value"; + return "in " + attrName + " attribute of " + ruleType + " rule " + ruleName + ": attribute " + + "must be non empty"; } protected String getErrorMsgMandatoryMissing(String attrName, String ruleType) { -- cgit v1.2.3