From 1e597c85c6881b7cdf208397f4ad836c7f69185a Mon Sep 17 00:00:00 2001
From: Ulf Adams <ulfjack@google.com>
Date: Wed, 23 Sep 2015 16:54:19 +0000
Subject: Simplify LoadingPhaseRunner; avoid an unnecessary Set copy.

--
MOS_MIGRATED_REVID=103754837
---
 .../com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'src/main')

diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java
index 280123378b..0781b64e67 100644
--- a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java
+++ b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java
@@ -537,9 +537,8 @@ public class LoadingPhaseRunner {
     }
   }
 
-  private Collection<Target> getTargetsForLabels(Collection<Label> labels) {
+  private Set<Target> getTargetsForLabels(Collection<Label> labels) {
     Set<Target> result = new HashSet<>();
-
     for (Label label : labels) {
       try {
         result.add(packageManager.getLoadedTarget(label));
@@ -547,7 +546,6 @@ public class LoadingPhaseRunner {
         throw new IllegalStateException(e);  // The target should have been loaded
       }
     }
-
     return result;
   }
 
@@ -573,7 +571,7 @@ public class LoadingPhaseRunner {
     }
 
     return ImmutableSet.copyOf(Sets.difference(ImmutableSet.copyOf(targetsToLoad),
-        ImmutableSet.copyOf(getTargetsForLabels(rootCauses.keySet()))));
+        getTargetsForLabels(rootCauses.keySet())));
   }
 
   /**
-- 
cgit v1.2.3