From 73d738e483bb428083185c5bb92b4fe6ecfe0834 Mon Sep 17 00:00:00 2001 From: Damien Martin-Guillerez Date: Thu, 13 Oct 2016 19:45:30 +0000 Subject: Fix IllegalStateException when reloading several time the same extension Fixes #1469. -- Change-Id: I3ffc18208ba346e03658ebeb4d2bb5938113a476 Reviewed-on: https://bazel-review.googlesource.com/6615 MOS_MIGRATED_REVID=136073702 --- .../com/google/devtools/build/lib/packages/WorkspaceFactory.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/main/java') diff --git a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java index 12c5caa66b..ba1440f2c4 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java +++ b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java @@ -49,6 +49,7 @@ import com.google.devtools.build.lib.syntax.SkylarkList; import com.google.devtools.build.lib.syntax.SkylarkSignatureProcessor; import com.google.devtools.build.lib.vfs.Path; import java.io.File; +import java.util.HashMap; import java.util.Map; import java.util.regex.Matcher; import java.util.regex.Pattern; @@ -181,11 +182,9 @@ public class WorkspaceFactory { .setGlobals(Environment.BUILD) .setEventHandler(localReporter); if (importedExtensions != null) { - importMap = - ImmutableMap.builder() - .putAll(parentImportMap) - .putAll(importedExtensions) - .build(); + Map map = new HashMap(parentImportMap); + map.putAll(importedExtensions); + importMap = ImmutableMap.copyOf(importedExtensions); } else { importMap = parentImportMap; } -- cgit v1.2.3