From 2f80e5895fbcc4fc4102e57660cd631eba731b04 Mon Sep 17 00:00:00 2001
From: Dmitry Lomov <dslomov@google.com>
Date: Mon, 22 Jan 2018 11:18:20 -0800
Subject: Only allow files created by the same rule as executable outputs of a
 rule.

Fixes #4170.

Change-Id: I308ee17eb769dcc6a94b90b1dd6cc2ccbe14e968
PiperOrigin-RevId: 182807196
---
 .../lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java     | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'src/main/java/com')

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java
index a40bacb549..d22857e84d 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkRuleConfiguredTargetUtil.java
@@ -387,6 +387,14 @@ public final class SkylarkRuleConfiguredTargetUtil {
         defaultRunfiles = cast("default_runfiles", provider, Runfiles.class, loc);
       } else if (field.equals("executable")) {
         executable = cast("executable", provider, Artifact.class, loc);
+        if (!executable.getArtifactOwner().equals(context.getRuleContext().getOwner())) {
+          throw new EvalException(
+              loc,
+              String.format(
+                  "'executable' provided by an executable rule '%s' should be created "
+                      + "by the same rule.",
+                  context.getRuleContext().getRule().getRuleClass()));
+        }
       } else if (provider
           .getProvider()
           .getKey()
-- 
cgit v1.2.3