From 21a01ff03f3dd817bd7bba52b9b3b8c81c49cde6 Mon Sep 17 00:00:00 2001 From: tomlu Date: Wed, 21 Jun 2017 23:57:33 +0200 Subject: Fix source jars no longer being exposed to Skylark from java_library. Regression test added for java_library. Unfortunately, due to the nature of the skylark provider, similar regression tests should probably be added to every Java providing rule. In the long term, the better solution is to expose JavaProvider directly and remove JavaSkylarkApiProvider. Fixes #3238 PiperOrigin-RevId: 159748655 --- src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java | 1 + 1 file changed, 1 insertion(+) (limited to 'src/main/java/com/google') diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java index c08ddb7f2c..81f051d813 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java @@ -239,6 +239,7 @@ public class JavaLibrary implements RuleConfiguredTargetFactory { // TODO(bazel-team): this should only happen for java_plugin .addProvider(JavaCommon.getTransitivePlugins(ruleContext)) .addProvider(new ProguardSpecProvider(proguardSpecs)) + .addProvider(sourceJarsProvider) .addOutputGroup(JavaSemantics.SOURCE_JARS_OUTPUT_GROUP, transitiveSourceJars) .addOutputGroup(OutputGroupProvider.HIDDEN_TOP_LEVEL, proguardSpecs); -- cgit v1.2.3