From 10911f1a25040e8237b1b80971651e03279d8473 Mon Sep 17 00:00:00 2001 From: nharmata Date: Wed, 8 Aug 2018 07:58:21 -0700 Subject: Add a comment clarifying the soundness of not doing edge filtering during the DTC construction of the universe argument to 'rdeps'. RELNOTES: None PiperOrigin-RevId: 207884395 --- .../com/google/devtools/build/lib/query2/SkyQueryEnvironment.java | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/main/java/com/google') diff --git a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java index 0c759a8444..8918af1ea1 100644 --- a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java +++ b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java @@ -1208,6 +1208,9 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment QueryExpressionContext context, Callback callback) { return transformAsync( + // Even if we need to do edge filtering, it's fine to construct the rdeps universe via an + // unfiltered DTC visitation; the subsequent rdeps visitation will perform the edge + // filtering. getUnfilteredUniverseDTCSkyKeyPredicateFuture(universe, context), unfilteredUniversePredicate -> ParallelSkyQueryUtils.getRdepsInUniverseUnboundedParallel( this, expression, unfilteredUniversePredicate, context, callback, packageSemaphore)); @@ -1236,6 +1239,9 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment QueryExpressionContext context, Callback callback) { return transformAsync( + // Even if we need to do edge filtering, it's fine to construct the rdeps universe via an + // unfiltered DTC visitation; the subsequent rdeps visitation will perform the edge + // filtering. getUnfilteredUniverseDTCSkyKeyPredicateFuture(universe, context), universePredicate -> ParallelSkyQueryUtils.getRdepsInUniverseBoundedParallel( this, expression, depth, universePredicate, context, callback, packageSemaphore)); -- cgit v1.2.3