From 5f026f96118e76c8a6357c61e5710e0bd1bf0f54 Mon Sep 17 00:00:00 2001 From: Damien Martin-Guillerez Date: Wed, 19 Oct 2016 13:49:54 +0000 Subject: Rollback of commit e6191f7209ebf3f67480bc7aa9db5ac58beb2156. *** Reason for rollback *** Roll-forward with fix. Tested with `bazel build src:srcs //src/test/...` using a bootstrapped bazel. Fixes #1923. RELNOTES[INC]: Non test-only targets can no longer depends on test-only targets. *** Original change description *** Automated [] rollback of commit a9f20b0d6459d395444c45cf5e94a899f3443633. *** Reason for rollback *** Broke Bazel CI: ERROR: /home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/src/BUILD:284:1: in filegroup rule //src:srcs: non-test target '//src:srcs' depends on testonly target '//src/java_tools/junitrunner/java/com/google/testing/junit/junit4:srcs' and doesn't have testonly attribute set. ERROR: Analysis of target '//scripts/packages:packages' failed; build aborted. http://ci.bazel.io/view/Bazel%20b... *** -- MOS_MIGRATED_REVID=136589937 --- src/main/java/com/google/devtools/skylark/BUILD | 1 + 1 file changed, 1 insertion(+) (limited to 'src/main/java/com/google/devtools/skylark') diff --git a/src/main/java/com/google/devtools/skylark/BUILD b/src/main/java/com/google/devtools/skylark/BUILD index 6a05f40d18..c4d147ca0a 100644 --- a/src/main/java/com/google/devtools/skylark/BUILD +++ b/src/main/java/com/google/devtools/skylark/BUILD @@ -15,5 +15,6 @@ java_binary( filegroup( name = "srcs", + testonly = 0, # All srcs should be not test only, overwrite package default. srcs = glob(["**"]), ) -- cgit v1.2.3