From bd0c7bb0a7cb0e1c52265022e84cb5c7553f46dc Mon Sep 17 00:00:00 2001
From: Francois-Rene Rideau <tunes@google.com>
Date: Mon, 21 Sep 2015 16:54:19 +0000
Subject: Hush Environment#toString()

Don't print the contents of an Environment, it only confuses users.

--
MOS_MIGRATED_REVID=103554964
---
 .../devtools/build/lib/syntax/Environment.java     | 29 ++--------------------
 1 file changed, 2 insertions(+), 27 deletions(-)

(limited to 'src/main/java/com/google/devtools/build')

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
index 266c2c79aa..c283157d41 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
@@ -158,14 +158,7 @@ public final class Environment implements Freezable {
 
     @Override
     public String toString() {
-      String prefix = "Frame";
-      StringBuilder sb = new StringBuilder();
-      for (Frame f = this; f != null; f = f.parent) {
-        Printer.formatTo(sb, "%s%s%r",
-            ImmutableList.<Object>of(prefix, f.mutability(), f.bindings));
-        prefix = "=>";
-      }
-      return sb.toString();
+      return String.format("<Frame%s>", mutability());
     }
   }
 
@@ -772,25 +765,7 @@ public final class Environment implements Freezable {
 
   @Override
   public String toString() {
-    StringBuilder out = new StringBuilder();
-    out.append("Environment(lexicalFrame=");
-    out.append(lexicalFrame);
-    out.append(", globalFrame=");
-    out.append(globalFrame);
-    out.append(", dynamicFrame=");
-    out.append(dynamicFrame);
-    out.append(", eventHandler.getClass()=");
-    out.append(eventHandler.getClass());
-    out.append(", importedExtensions=");
-    out.append(importedExtensions);
-    out.append(", isSkylark=");
-    out.append(isSkylark);
-    out.append(", fileContentHashCode=");
-    out.append(fileContentHashCode);
-    out.append(", isLoadingPhase=");
-    out.append(isLoadingPhase);
-    out.append(")");
-    return out.toString();
+    return String.format("<Environment%s>", mutability());
   }
 
   /**
-- 
cgit v1.2.3