From 4cf2ebdcef7b5d4c46e533a560642b89eb3f02a5 Mon Sep 17 00:00:00 2001 From: ulfjack Date: Mon, 11 Jun 2018 06:00:36 -0700 Subject: Add AutoProfiler-like API to Profiler - migrate all startTask/completeTask pairs to the new API PiperOrigin-RevId: 200038703 --- .../build/skyframe/AbstractExceptionalParallelEvaluator.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/main/java/com/google/devtools/build/skyframe') diff --git a/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java index 7771d833ec..9d7bf274f9 100644 --- a/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/AbstractExceptionalParallelEvaluator.java @@ -22,6 +22,7 @@ import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadCompatible; import com.google.devtools.build.lib.events.ExtendedEventHandler; import com.google.devtools.build.lib.profiler.Profiler; import com.google.devtools.build.lib.profiler.ProfilerTask; +import com.google.devtools.build.lib.profiler.SilentCloseable; import com.google.devtools.build.lib.util.GroupedList; import com.google.devtools.build.skyframe.EvaluationProgressReceiver.EvaluationState; import com.google.devtools.build.skyframe.EvaluationProgressReceiver.EvaluationSuccessState; @@ -211,11 +212,9 @@ public abstract class AbstractExceptionalParallelEvaluator } } - Profiler.instance().startTask(ProfilerTask.SKYFRAME_EVAL, "Parallel Evaluator evaluation"); - try { + try (SilentCloseable c = + Profiler.instance().profile(ProfilerTask.SKYFRAME_EVAL, "Parallel Evaluator evaluation")) { return doMutatingEvaluation(skyKeySet); - } finally { - Profiler.instance().completeTask(ProfilerTask.SKYFRAME_EVAL); } } -- cgit v1.2.3