From 5bd26b24a643432c962b6256876b6729199c03d9 Mon Sep 17 00:00:00 2001 From: Nathan Harmata Date: Mon, 14 Nov 2016 19:55:50 +0000 Subject: Make TargetPattern evaluation during query evaluation more parallel-friendly by introducing TargetPattern#parEval, which allows TargetPatterns' evaluations to explicitly have parallel implementations (no need to secretly use a FJP). -- MOS_MIGRATED_REVID=139101922 --- .../build/lib/util/SynchronizedBatchCallback.java | 33 ++++++++++++++++++++++ .../build/lib/util/ThreadSafeBatchCallback.java | 21 ++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 src/main/java/com/google/devtools/build/lib/util/SynchronizedBatchCallback.java create mode 100644 src/main/java/com/google/devtools/build/lib/util/ThreadSafeBatchCallback.java (limited to 'src/main/java/com/google/devtools/build/lib/util') diff --git a/src/main/java/com/google/devtools/build/lib/util/SynchronizedBatchCallback.java b/src/main/java/com/google/devtools/build/lib/util/SynchronizedBatchCallback.java new file mode 100644 index 0000000000..ec7bd17a5d --- /dev/null +++ b/src/main/java/com/google/devtools/build/lib/util/SynchronizedBatchCallback.java @@ -0,0 +1,33 @@ +// Copyright 2016 The Bazel Authors. All rights reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package com.google.devtools.build.lib.util; + +/** + * A {@link ThreadSafeBatchCallback} that trivially delegates to a {@link BatchCallback} in a + * synchronized manner. + */ +public class SynchronizedBatchCallback + implements ThreadSafeBatchCallback { + private final BatchCallback delegate; + + public SynchronizedBatchCallback(BatchCallback delegate) { + this.delegate = delegate; + } + + @Override + public synchronized void process(Iterable partialResult) throws E, InterruptedException { + delegate.process(partialResult); + } +} + diff --git a/src/main/java/com/google/devtools/build/lib/util/ThreadSafeBatchCallback.java b/src/main/java/com/google/devtools/build/lib/util/ThreadSafeBatchCallback.java new file mode 100644 index 0000000000..2fed9cc292 --- /dev/null +++ b/src/main/java/com/google/devtools/build/lib/util/ThreadSafeBatchCallback.java @@ -0,0 +1,21 @@ +// Copyright 2016 The Bazel Authors. All rights reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package com.google.devtools.build.lib.util; + +import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe; + +/** Marker interface for a {@link BatchCallback} that is {@link ThreadSafe}. */ +@ThreadSafe +public interface ThreadSafeBatchCallback extends BatchCallback { +} \ No newline at end of file -- cgit v1.2.3