From 8040b0b7690420be2f92071e635cd1d7f18a38e9 Mon Sep 17 00:00:00 2001 From: nharmata Date: Tue, 9 May 2017 13:53:19 -0400 Subject: Introduce an EvaluationProgressReceiver implementation that does nothing. This is useful for dealing with all the existing implementations in the face of interface changes that are irrelevant. RELNOTES: None PiperOrigin-RevId: 155525021 --- .../google/devtools/build/lib/skyframe/SkyframeBuildView.java | 9 ++------- .../com/google/devtools/build/lib/skyframe/SkyframeExecutor.java | 6 ++---- 2 files changed, 4 insertions(+), 11 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java index 2ddbf975d1..14a96e5120 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java @@ -603,7 +603,8 @@ public final class SkyframeBuildView { this.enableAnalysis = enable; } - private class ConfiguredTargetValueProgressReceiver implements EvaluationProgressReceiver { + private class ConfiguredTargetValueProgressReceiver + extends EvaluationProgressReceiver.NullEvaluationProgressReceiver { @Override public void invalidated(SkyKey skyKey, InvalidationState state) { if (skyKey.functionName().equals(SkyFunctions.CONFIGURED_TARGET)) { @@ -619,12 +620,6 @@ public final class SkyframeBuildView { } } - @Override - public void enqueueing(SkyKey skyKey) {} - - @Override - public void computed(SkyKey skyKey, long elapsedTimeNanos) {} - @Override public void evaluated(SkyKey skyKey, Supplier skyValueSupplier, EvaluationState state) { diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java index d2dba4c96a..77d8394679 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java @@ -1950,7 +1950,8 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory { /** * A progress received to track analysis invalidation and update progress messages. */ - protected class SkyframeProgressReceiver implements EvaluationProgressReceiver { + protected class SkyframeProgressReceiver + extends EvaluationProgressReceiver.NullEvaluationProgressReceiver { /** * This flag is needed in order to avoid invalidating legacy data when we clear the * analysis cache because of --discard_analysis_cache flag. For that case we want to keep @@ -1980,9 +1981,6 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory { } } - @Override - public void computed(SkyKey skyKey, long elapsedTimeNanos) {} - @Override public void evaluated(SkyKey skyKey, Supplier valueSupplier, EvaluationState state) { if (ignoreInvalidations) { -- cgit v1.2.3