From f745e99db7632cfb2145b6926f961e85f9084bc5 Mon Sep 17 00:00:00 2001 From: Janak Ramakrishnan Date: Thu, 3 Mar 2016 08:08:50 +0000 Subject: Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn. -- MOS_MIGRATED_REVID=116224565 --- .../java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java index bbf927792e..f247bdeda6 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternValue.java @@ -144,7 +144,7 @@ public final class TargetPatternValue implements SkyValue { !positive, offset, ImmutableSet.of()); - SkyKey skyKey = new SkyKey(SkyFunctions.TARGET_PATTERN, targetPatternKey); + SkyKey skyKey = SkyKey.create(SkyFunctions.TARGET_PATTERN, targetPatternKey); builder.add(new TargetPatternSkyKeyValue(skyKey)); } return builder.build(); -- cgit v1.2.3