From e7552c53a5dd65ae496562fc29adecd89e9db5fb Mon Sep 17 00:00:00 2001 From: tomlu Date: Fri, 19 Jan 2018 10:25:19 -0800 Subject: Fix usages of PathFragment segments that will become inefficient. An upcoming replacement to PathFragment will not have efficient segment semantics, causing code to become unnecessarily inefficient. RELNOTES: None PiperOrigin-RevId: 182553098 --- .../com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java index 4bf54fcc46..bedd9ba159 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java @@ -149,7 +149,7 @@ public final class FilesetEntryFunction implements SkyFunction { DirectoryTree root = new DirectoryTree(); for (ResolvedFile f : rftv.getTransitiveFiles().toCollection()) { PathFragment path = f.getNameInSymlinkTree().relativeTo(prefixToRemove); - if (path.segmentCount() > 0) { + if (!path.isEmpty()) { path = t.getDestPath().getRelative(path); DirectoryTree dir = root; for (int i = 0; i < path.segmentCount() - 1; ++i) { -- cgit v1.2.3