From 6ed4fd55ac792b4b6a5003cb1530a5a8b1b8b55d Mon Sep 17 00:00:00 2001 From: tomlu Date: Tue, 3 Apr 2018 10:01:10 -0700 Subject: Fix build results for aspect builds. The current output was pretty much completely incorrect. However since the result output was always hidden for the default value of --show_result, users simply didn't see the incorrect output (instead getting no output at all). This CL fixes both the --show_result problem and makes the output correct. RELNOTES: Print correct build result for builds with --aspects flag. PiperOrigin-RevId: 191456352 --- .../com/google/devtools/build/lib/skyframe/AspectCompletionValue.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletionValue.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletionValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletionValue.java index 7b33d0bfe4..64066cf948 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletionValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletionValue.java @@ -37,8 +37,9 @@ public class AspectCompletionValue implements SkyValue { targets, aspectValue -> AspectCompletionKey.create(aspectValue.getKey(), ctx)); } + /** The key of an AspectCompletionValue. */ @AutoValue - abstract static class AspectCompletionKey implements SkyKey { + public abstract static class AspectCompletionKey implements SkyKey { public static AspectCompletionKey create( AspectKey aspectKey, TopLevelArtifactContext topLevelArtifactContext) { return new AutoValue_AspectCompletionValue_AspectCompletionKey( -- cgit v1.2.3