From 8529746358ff5d88dc7ddf584a85ba0aa1a269a8 Mon Sep 17 00:00:00 2001 From: gregce Date: Fri, 18 Aug 2017 21:20:29 +0200 Subject: Replace TransitionApplier interface with a dedicated class. This accomplishes a few goals: 1. Removes the outdated BuildConfiguration.StaticConfigurationApplier code. 2. Removes the TransitionApplier abstraction completely. This was an awkward bridge meant to support both static and dynamic implementations. 3. Moves transition logic to its own dedicated class: ConfigurationResolver. This no longer belongs in BuildConfiguration, which we ultimately want to become a simple map. Part of the static config cleanup effort. PiperOrigin-RevId: 165736955 --- .../java/com/google/devtools/build/lib/rules/cpp/CppRuleClasses.java | 1 - 1 file changed, 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules') diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppRuleClasses.java index 5f109739b4..06e4c9b687 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppRuleClasses.java @@ -101,7 +101,6 @@ public class CppRuleClasses { ImmutableMap.of( Attribute.ConfigurationTransition.DATA, DisableLipoTransition.INSTANCE, LipoTransition.LIPO_COLLECTOR, LipoContextCollectorTransition.INSTANCE - // TARGET_CONFIG_FOR_LIPO has no entry because only static configurations use it. ); -- cgit v1.2.3