From 2d5035685a6180e6abfa7e93d7ee4b7ec0632510 Mon Sep 17 00:00:00 2001 From: John Cater Date: Tue, 21 Nov 2017 07:23:28 -0800 Subject: Change Platform.remoteExecutionProperties to be a String, not a dict. This is needed for the ability to synthesize the correct remote execution protos from a platform rule. Part of #4128. Change-Id: I7fa8acf45642a4df4e2beb1ba9c57c2536670486 PiperOrigin-RevId: 176504885 --- .../com/google/devtools/build/lib/rules/platform/PlatformRule.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules/platform/PlatformRule.java') diff --git a/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformRule.java b/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformRule.java index 74e824f9f6..1abe56accd 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformRule.java @@ -49,9 +49,11 @@ public class PlatformRule implements RuleDefinition { .mandatoryProviders(ImmutableList.of(ConstraintValueInfo.SKYLARK_CONSTRUCTOR.id()))) /* - A key/value dict of values that will be sent to a remote execution platform. + A text proto (the Platform message from + https://github.com/googleapis/googleapis/blob/master/google/devtools/remoteexecution/v1test/remote_execution.proto) + that will be sent to a remote execution platform. */ - .add(attr(REMOTE_EXECUTION_PROPS_ATTR, Type.STRING_DICT)) + .add(attr(REMOTE_EXECUTION_PROPS_ATTR, Type.STRING)) // Undocumented. Indicates that this platform should auto-configure the platform constraints // based on the current host OS and CPU settings. -- cgit v1.2.3