From 1b44df38b6e7979b58988e264a4c04b1b6146c85 Mon Sep 17 00:00:00 2001 From: Googler Date: Thu, 2 Mar 2017 18:33:31 +0000 Subject: Add dSYM binaries to AppleDebugOutputsProvider. RELNOTES: Per-architecture dSYM binaries are now propagated by apple_binary's AppleDebugOutputsProvider. -- PiperOrigin-RevId: 149019153 MOS_MIGRATED_REVID=149019153 --- .../build/lib/rules/objc/AppleDebugOutputsProvider.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc/AppleDebugOutputsProvider.java') diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleDebugOutputsProvider.java b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleDebugOutputsProvider.java index b25c61630b..9484a50498 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleDebugOutputsProvider.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleDebugOutputsProvider.java @@ -33,10 +33,10 @@ import java.util.Map.Entry; * Artifact, output_type: Artifact, ... } } * *

Where {@code arch} is any Apple architecture such as "arm64" or "armv7", {@code output_type} - * is currently "bitcode_symbols", and the artifact is an instance of the {@link - * Artifact} class. + * can currently be "bitcode_symbols" or "dsym_binary", and the artifact is an instance of the + * {@link Artifact} class. * - *

Example: { "arm64": { "bitcode_symbols": Artifact } } + *

Example: { "arm64": { "bitcode_symbols": Artifact, "dsym_binary": Artifact } } */ @Immutable public final class AppleDebugOutputsProvider extends SkylarkClassObject @@ -45,10 +45,11 @@ public final class AppleDebugOutputsProvider extends SkylarkClassObject /** Expected types of debug outputs. */ enum OutputType { - // TODO(b/33839914): Add DWARF binaries for dSYM outputs. - /** A Bitcode symbol map, per architecture. */ - BITCODE_SYMBOLS; + BITCODE_SYMBOLS, + + /** A single-architecture DWARF binary with debug symbols. */ + DSYM_BINARY; @Override public String toString() { -- cgit v1.2.3