From 90cdca8d2715a698630e13b6d2e71b44d76abf82 Mon Sep 17 00:00:00 2001
From: Lukacs Berki <lberki@google.com>
Date: Tue, 7 Feb 2017 08:41:36 +0000
Subject: Do not store two profile artifacts in FdoSupportProvider.

--
PiperOrigin-RevId: 146757663
MOS_MIGRATED_REVID=146757663
---
 .../devtools/build/lib/rules/cpp/FdoSupport.java       | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

(limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/FdoSupport.java')

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/FdoSupport.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/FdoSupport.java
index 21697c8b46..53fa0de33f 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/FdoSupport.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/FdoSupport.java
@@ -699,9 +699,10 @@ public class FdoSupport {
     if (!featureConfiguration.isEnabled(CppRuleClasses.AUTOFDO)) {
       return null;
     }
-    buildVariables.addStringVariable("fdo_profile_path", getAutoProfilePath(
-        fdoProfile, fdoRootExecPath).getPathString());
-    return getFdoSupportProvider(ruleContext).getAutoProfileArtifact();
+
+    Artifact profile = getFdoSupportProvider(ruleContext).getProfileArtifact();
+    buildVariables.addStringVariable("fdo_profile_path", profile.getExecPathString());
+    return profile;
   }
 
   /**
@@ -716,7 +717,7 @@ public class FdoSupport {
   public FdoSupportProvider createFdoSupportProvider(
       RuleContext ruleContext) {
     if (fdoRoot == null) {
-      return new FdoSupportProvider(this, null, null, null);
+      return new FdoSupportProvider(this, null, null);
     }
 
     Preconditions.checkState(fdoPath != null);
@@ -726,12 +727,6 @@ public class FdoSupport {
     Artifact profileArtifact = ruleContext.getAnalysisEnvironment().getDerivedArtifact(
         fdoPath.getRelative(profileRootRelativePath), fdoRoot);
     ruleContext.registerAction(new FdoStubAction(ruleContext.getActionOwner(), profileArtifact));
-
-    Artifact autoProfileArtifact = ruleContext.getAnalysisEnvironment().getDerivedArtifact(
-        fdoPath.getRelative(getAutoProfileRootRelativePath(fdoProfile)), fdoRoot);
-    ruleContext.getAnalysisEnvironment().registerAction(
-        new FdoStubAction(ruleContext.getActionOwner(), autoProfileArtifact));
-
     Preconditions.checkState(fdoPath != null);
     ImmutableMap.Builder<PathFragment, Artifact> gcdaArtifacts = ImmutableMap.builder();
     for (PathFragment path : gcdaFiles) {
@@ -741,8 +736,7 @@ public class FdoSupport {
       gcdaArtifacts.put(path, gcdaArtifact);
     }
 
-    return new FdoSupportProvider(
-        this, profileArtifact, autoProfileArtifact, gcdaArtifacts.build());
+    return new FdoSupportProvider(this, profileArtifact, gcdaArtifacts.build());
   }
 
   private static FdoSupportProvider getFdoSupportProvider(RuleContext ruleContext) {
-- 
cgit v1.2.3