From a02b2767ce275b152ed647974e1dc074d0ad3007 Mon Sep 17 00:00:00 2001 From: Cal Peyser Date: Fri, 23 Sep 2016 14:04:28 +0000 Subject: Rollback of commit 4946ab9d5b5d78862c043e35342107a1b9b2f398. *** Reason for rollback *** We *still* have case discrepancies in objc code, which appears to be a hard blocker to .d pruning. This change will not work until we've found some way to enforce case-consistency. *** Original change description *** Implement input pruning using .d files in objc. -- MOS_MIGRATED_REVID=134069949 --- .../build/lib/rules/cpp/FakeCppCompileAction.java | 33 ++++------------------ 1 file changed, 5 insertions(+), 28 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/FakeCppCompileAction.java') diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/FakeCppCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/FakeCppCompileAction.java index f7c47301ae..ad7d5fe735 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/FakeCppCompileAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/FakeCppCompileAction.java @@ -34,7 +34,6 @@ import com.google.devtools.build.lib.analysis.RuleContext; import com.google.devtools.build.lib.analysis.config.BuildConfiguration; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.collect.nestedset.NestedSet; -import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadCompatible; import com.google.devtools.build.lib.events.Event; import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration; @@ -42,7 +41,6 @@ import com.google.devtools.build.lib.util.Preconditions; import com.google.devtools.build.lib.util.ShellEscaper; import com.google.devtools.build.lib.util.io.FileOutErr; import com.google.devtools.build.lib.vfs.FileSystemUtils; -import com.google.devtools.build.lib.vfs.Path; import com.google.devtools.build.lib.vfs.PathFragment; import java.io.IOException; import java.util.UUID; @@ -81,7 +79,7 @@ public class FakeCppCompileAction extends CppCompileAction { ImmutableList copts, Predicate nocopts, RuleContext ruleContext, - CppSemantics cppSemantics) { + CppSemantics semantics) { super( owner, features, @@ -119,7 +117,7 @@ public class FakeCppCompileAction extends CppCompileAction { ImmutableMap.of(), CppCompileAction.CPP_COMPILE, ruleContext, - cppSemantics); + semantics); this.tempOutputFile = Preconditions.checkNotNull(tempOutputFile); } @@ -150,30 +148,9 @@ public class FakeCppCompileAction extends CppCompileAction { } } IncludeScanningContext scanningContext = executor.getContext(IncludeScanningContext.class); - Path execRoot = executor.getExecRoot(); - - NestedSet discoveredInputs; - if (getDotdFile() == null) { - discoveredInputs = NestedSetBuilder.stableOrder().build(); - } else { - HeaderDiscovery.Builder discoveryBuilder = new HeaderDiscovery.Builder() - .setAction(this) - .setDotdFile(getDotdFile()) - .setSourceFile(getSourceFile()) - .setSpecialInputsHandler(specialInputsHandler) - .setDependencySet(processDepset(execRoot, reply)) - .setPermittedSystemIncludePrefixes(getPermittedSystemIncludePrefixes(execRoot)) - .setAllowedDerivedinputsMap(getAllowedDerivedInputsMap()); - - if (cppSemantics.needsIncludeValidation()) { - discoveryBuilder.shouldValidateInclusions(); - } - - discoveredInputs = discoveryBuilder - .build() - .discoverInputsFromDotdFiles(execRoot, scanningContext.getArtifactResolver()); - } - + NestedSet discoveredInputs = + discoverInputsFromDotdFiles( + executor.getExecRoot(), scanningContext.getArtifactResolver(), reply); reply = null; // Clear in-memory .d files early. // Even cc_fake_binary rules need to properly declare their dependencies... -- cgit v1.2.3