From 8610d97d2b68cfbcf6b7de4441665a64f378eb9c Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Mon, 27 Nov 2017 03:14:43 -0800 Subject: Shape sharing for Skylark providers. Add CompactSkylarkInfo, which stores its values as an array instead of a map. The space savings will probably not be dramatic because providers usually have a limited amount of keys. But, there are a lot of them! Change-Id: Idd452a5e3982f773b1c5202c73f3d7031ec022c6 PiperOrigin-RevId: 176995376 --- .../java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules/apple') diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java b/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java index f0cb1644c2..fa061530cf 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java +++ b/src/main/java/com/google/devtools/build/lib/rules/apple/ApplePlatform.java @@ -234,7 +234,7 @@ public enum ApplePlatform implements SkylarkValue { for (ApplePlatform type : values()) { fields.put(type.skylarkKey, type); } - return new SkylarkInfo(constructor, fields, Location.BUILTIN); + return SkylarkInfo.fromMap(constructor, fields, Location.BUILTIN); } @Override @@ -308,7 +308,7 @@ public enum ApplePlatform implements SkylarkValue { for (PlatformType type : values()) { fields.put(type.skylarkKey, type); } - return new SkylarkInfo(constructor, fields, Location.BUILTIN); + return SkylarkInfo.fromMap(constructor, fields, Location.BUILTIN); } @Override -- cgit v1.2.3