From 77ba65e96a62dfb740f1be844d484abc7f3286af Mon Sep 17 00:00:00 2001 From: Googler Date: Mon, 26 Jun 2017 19:55:09 +0200 Subject: Refactor SkyQueryEnvironment to allow preprocessing or postprocessing targets Refactor SkyQueryEnvironment and a few other query helpers to make it easier to work with targets. RELNOTES: None PiperOrigin-RevId: 160165398 --- .../devtools/build/lib/query2/engine/TestsFunction.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/query2/engine/TestsFunction.java') diff --git a/src/main/java/com/google/devtools/build/lib/query2/engine/TestsFunction.java b/src/main/java/com/google/devtools/build/lib/query2/engine/TestsFunction.java index 15950d7114..0331d480c5 100644 --- a/src/main/java/com/google/devtools/build/lib/query2/engine/TestsFunction.java +++ b/src/main/java/com/google/devtools/build/lib/query2/engine/TestsFunction.java @@ -30,19 +30,18 @@ import java.util.List; import java.util.Set; /** - * A tests(x) filter expression, which returns all the tests in set x, - * expanding test_suite rules into their constituents. + * A tests(x) filter expression, which returns all the tests in set x, expanding test_suite rules + * into their constituents. * - *

Unfortunately this class reproduces a substantial amount of logic from - * {@code TestSuiteConfiguredTarget}, albeit in a somewhat simplified form. - * This is basically inevitable since the expansion of test_suites cannot be - * done during the loading phase, because it involves inter-package references. - * We make no attempt to validate the input, or report errors or warnings other - * than missing target. + *

Unfortunately this class reproduces a substantial amount of logic from {@code + * TestSuiteConfiguredTarget}, albeit in a somewhat simplified form. This is basically inevitable + * since the expansion of test_suites cannot be done during the loading phase, because it involves + * inter-package references. We make no attempt to validate the input, or report errors or warnings + * other than missing target. * *

expr ::= TESTS '(' expr ')'
*/ -class TestsFunction implements QueryFunction { +public class TestsFunction implements QueryFunction { TestsFunction() { } -- cgit v1.2.3