From 6ae05b419922193c4c253e51c9a5e483e4f947fa Mon Sep 17 00:00:00 2001 From: janakr Date: Mon, 13 Aug 2018 16:13:42 -0700 Subject: Order Skyframe evaluations in a priority queue, with all children of a given node having the same priority, later enqueueings having higher priority, re-enqueued nodes having highest priority, and new root nodes having lowest priority. Experimentally, this can save significant RAM (1.4G in some builds!) while not affecting speed. Also do a semi-drive-by deleting ExecutorFactory parameter to AbstractQueueVisitor, since it was always AbstractQueueVisitor.EXECUTOR_FACTORY. PiperOrigin-RevId: 208560889 --- src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java | 1 - 1 file changed, 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java') diff --git a/src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java b/src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java index af06cde70e..b65538ccb9 100644 --- a/src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java +++ b/src/main/java/com/google/devtools/build/lib/query2/LabelVisitor.java @@ -249,7 +249,6 @@ final class LabelVisitor { TimeUnit.SECONDS, !keepGoing, THREAD_NAME, - AbstractQueueVisitor.EXECUTOR_FACTORY, ErrorClassifier.DEFAULT); this.eventHandler = eventHandler; this.maxDepth = maxDepth; -- cgit v1.2.3