From d6fce4428db80f8e5d369581baea415e202cfe62 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Wed, 14 Oct 2015 10:08:25 +0000 Subject: Reimplement target pattern parsing in Skyframe. This is currently not hooked up, and we're passing (potentially) massive numbers of targets around. -- MOS_MIGRATED_REVID=105395404 --- .../com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java') diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java index 24043d3b1a..f5844f0350 100644 --- a/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java +++ b/src/main/java/com/google/devtools/build/lib/pkgcache/LoadingPhaseRunner.java @@ -369,6 +369,7 @@ public class LoadingPhaseRunner { callback.notifyTargets(targets.getTargets()); } maybeReportDeprecation(eventHandler, targets.getTargets()); + if (enableLoading) { return doLoadingPhase(eventHandler, eventBus, targets, testsToRun, labelsToLoadUnconditionally, keepGoing, options.loadingPhaseThreads, callback); @@ -635,7 +636,8 @@ public class LoadingPhaseRunner { * style warnings for the same target and it is a good thing; depending on a target and * wanting to build it are different things. */ - private void maybeReportDeprecation(EventHandler eventHandler, Collection targets) { + // Public for use by skyframe.TargetPatternPhaseFunction until this class goes away. + public static void maybeReportDeprecation(EventHandler eventHandler, Collection targets) { for (Rule rule : Iterables.filter(targets, Rule.class)) { if (rule.isAttributeValueExplicitlySpecified("deprecation")) { eventHandler.handle(Event.warn(rule.getLocation(), String.format( -- cgit v1.2.3