From 2e5ec0fd99ac4bfd930da99f6089dc5faf778464 Mon Sep 17 00:00:00 2001
From: Carmi Grushko <carmi@google.com>
Date: Wed, 21 Sep 2016 03:43:40 +0000
Subject: Make java_proto_library's strict_deps default to true. Remove
 package-level attribute to set the default of strict_deps. Change the
 semantics to --strict_deps_java_protos to mean force strict deps of all Java
 protos to be true regardless of their strict_deps attribute.

--
MOS_MIGRATED_REVID=133789725
---
 .../devtools/build/lib/packages/PackageFactory.java   | 19 -------------------
 1 file changed, 19 deletions(-)

(limited to 'src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java')

diff --git a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
index 4b8db490f3..86406f447a 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
@@ -262,24 +262,6 @@ public final class PackageFactory {
     }
   }
 
-  /**
-   * Declares the package() attribute specifying the default value for
-   * java_proto_library.strict_deps.
-   *
-   * <p>This attribute should be considered as undocumented/experimental, and is subject to change
-   * at any time without prior notice.
-   */
-  private static class DefaultStrictDepsJavaProtos extends PackageArgument<Boolean> {
-    private DefaultStrictDepsJavaProtos() {
-      super("default_strict_deps_java_protos", Type.BOOLEAN);
-    }
-
-    @Override
-    protected void process(Package.Builder pkgBuilder, Location location, Boolean value) {
-      pkgBuilder.setDefaultStrictDepsJavaProtos(value ? TriState.YES : TriState.NO);
-    }
-  }
-
   public static final String PKG_CONTEXT = "$pkg_context";
 
   // Used outside of Bazel!
@@ -481,7 +463,6 @@ public final class PackageFactory {
     ImmutableList.Builder<PackageArgument<?>> arguments =
         ImmutableList.<PackageArgument<?>>builder()
             .add(new DefaultDeprecation())
-            .add(new DefaultStrictDepsJavaProtos())
             .add(new DefaultDistribs())
             .add(new DefaultLicenses())
             .add(new DefaultTestOnly())
-- 
cgit v1.2.3