From 33aa1e1afd9f0c35f8ccadcf8bf8f29357ca2878 Mon Sep 17 00:00:00 2001 From: Lukacs Berki Date: Wed, 8 Jul 2015 08:11:30 +0000 Subject: Make globs work in remote repositories. This involved quite a few changes, mainly changing a bunch of places where we refer to packages by a PathFragment to PackageIdentifier. The only wart is the code in PathPackageLocator: ideally, it would just call into PackageLookupFunction. Unfortunately, it is (through globbing and Parser.include) called from within a Skyframe function, and we don't want to have two eval() calls going on at the same time, so we cannot use that. There is a potential correctness issue there: PathPackageLocator now assumes where external repositories are put and assumes that they are there when it gets control, but my understanding is that the associated RepositoryValue is always evaluated before, so it works out okay. -- MOS_MIGRATED_REVID=97751539 --- .../com/google/devtools/build/lib/packages/CachingPackageLocator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/packages/CachingPackageLocator.java') diff --git a/src/main/java/com/google/devtools/build/lib/packages/CachingPackageLocator.java b/src/main/java/com/google/devtools/build/lib/packages/CachingPackageLocator.java index f6badad9dd..3d677990f3 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/CachingPackageLocator.java +++ b/src/main/java/com/google/devtools/build/lib/packages/CachingPackageLocator.java @@ -40,6 +40,6 @@ public interface CachingPackageLocator { *

This method must be thread-safe. */ @ThreadSafe - Path getBuildFileForPackage(String packageName); + Path getBuildFileForPackage(PackageIdentifier packageName); } -- cgit v1.2.3