From c15ba2e54d0e17fe894bfeadb21228e0a76e9e40 Mon Sep 17 00:00:00 2001 From: Dmitry Lomov Date: Fri, 30 Oct 2015 15:50:01 +0000 Subject: Implement propagation along dependencies for Skylark aspects. -- MOS_MIGRATED_REVID=106694515 --- .../com/google/devtools/build/lib/packages/AspectClass.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/packages/AspectClass.java') diff --git a/src/main/java/com/google/devtools/build/lib/packages/AspectClass.java b/src/main/java/com/google/devtools/build/lib/packages/AspectClass.java index 9c829221b1..834379cfe3 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/AspectClass.java +++ b/src/main/java/com/google/devtools/build/lib/packages/AspectClass.java @@ -17,7 +17,13 @@ package com.google.devtools.build.lib.packages; /** * A class of aspects. * - *

This interface serves as a factory for {@link AspectFactory}. + *

This interface serves as a factory for {@code AspectFactory}. + * {@code AspectFactory} type argument is a placeholder for + * a {@link com.google.devtools.build.lib.analysis.ConfiguredAspectFactory}, which is + * an analysis-phase class. All loading-phase code uses {@code AspectClass<?>}, + * whereas analysis-phase code uses {@code AspectClass<ConfiguredAspectFactory>}. + * The latter is what all real implementations of this interface should implement. + * */ public interface AspectClass { @@ -26,8 +32,5 @@ public interface AspectClass { */ String getName(); - /** - * Instantiates an {@link AspectFactory} for this aspect class. - */ - AspectFactory newInstance(); + AspectDefinition getDefinition(); } -- cgit v1.2.3