From 0e24c69ff69c4d9f2dd1cc05eba9ca71a842dca8 Mon Sep 17 00:00:00 2001 From: Janak Ramakrishnan Date: Wed, 29 Apr 2015 19:50:26 +0000 Subject: Change getBatch signature from Set to Iterable since Iterable is all that's needed. Also clean up some lint warnings/unresolved references. -- MOS_MIGRATED_REVID=92380618 --- .../com/google/devtools/build/lib/concurrent/BatchedKeyedLocker.java | 5 +---- .../devtools/build/lib/concurrent/RefCountedMultisetKeyedLocker.java | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/concurrent') diff --git a/src/main/java/com/google/devtools/build/lib/concurrent/BatchedKeyedLocker.java b/src/main/java/com/google/devtools/build/lib/concurrent/BatchedKeyedLocker.java index d65b3c165d..748262a6fe 100644 --- a/src/main/java/com/google/devtools/build/lib/concurrent/BatchedKeyedLocker.java +++ b/src/main/java/com/google/devtools/build/lib/concurrent/BatchedKeyedLocker.java @@ -13,10 +13,7 @@ // limitations under the License. package com.google.devtools.build.lib.concurrent; -import com.google.devtools.build.lib.concurrent.KeyedLocker.AutoUnlocker; - import java.util.Comparator; -import java.util.Set; /** A {@link KeyedLocker} that additionally offers batched locking functionality. */ public interface BatchedKeyedLocker extends KeyedLocker { @@ -42,5 +39,5 @@ public interface BatchedKeyedLocker extends KeyedLocker { * *

Note that use of this method avoids the concerns described in {@link #lock}. */ - AutoUnlocker lockBatch(Set keys); + AutoUnlocker lockBatch(Iterable keys); } diff --git a/src/main/java/com/google/devtools/build/lib/concurrent/RefCountedMultisetKeyedLocker.java b/src/main/java/com/google/devtools/build/lib/concurrent/RefCountedMultisetKeyedLocker.java index 5cab307e4e..a2e089f6e2 100644 --- a/src/main/java/com/google/devtools/build/lib/concurrent/RefCountedMultisetKeyedLocker.java +++ b/src/main/java/com/google/devtools/build/lib/concurrent/RefCountedMultisetKeyedLocker.java @@ -21,7 +21,6 @@ import com.google.common.util.concurrent.Striped; import java.util.ArrayList; import java.util.Comparator; import java.util.List; -import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; import java.util.concurrent.atomic.AtomicBoolean; @@ -156,7 +155,7 @@ public class RefCountedMultisetKeyedLocker implements BatchedKeyedLocker { } @Override - public AutoUnlocker lockBatch(Set keys) { + public AutoUnlocker lockBatch(Iterable keys) { // This indicates the client did some unsafe casting - not our problem. Preconditions.checkNotNull(comparator); // We acquire locks in a consistent order. This prevents a deadlock that would otherwise occur -- cgit v1.2.3