From 152feb04f940385edaab01435454188488509fb3 Mon Sep 17 00:00:00 2001
From: Alex Humesky <ahumesky@google.com>
Date: Mon, 20 Jun 2016 19:43:11 +0000
Subject: Simplify the logic of determining output groups.

--
MOS_MIGRATED_REVID=125368119
---
 .../devtools/build/lib/buildtool/BuildRequest.java | 28 +---------------------
 1 file changed, 1 insertion(+), 27 deletions(-)

(limited to 'src/main/java/com/google/devtools/build/lib/buildtool/BuildRequest.java')

diff --git a/src/main/java/com/google/devtools/build/lib/buildtool/BuildRequest.java b/src/main/java/com/google/devtools/build/lib/buildtool/BuildRequest.java
index f5f67c275d..7642637660 100644
--- a/src/main/java/com/google/devtools/build/lib/buildtool/BuildRequest.java
+++ b/src/main/java/com/google/devtools/build/lib/buildtool/BuildRequest.java
@@ -19,7 +19,6 @@ import com.google.common.cache.CacheLoader;
 import com.google.common.cache.LoadingCache;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSortedSet;
-import com.google.common.collect.Sets;
 import com.google.devtools.build.lib.analysis.BuildView;
 import com.google.devtools.build.lib.analysis.OutputGroupProvider;
 import com.google.devtools.build.lib.analysis.TopLevelArtifactContext;
@@ -41,7 +40,6 @@ import com.google.devtools.common.options.OptionsProvider;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.ExecutionException;
 import java.util.regex.Pattern;
@@ -501,31 +499,7 @@ public class BuildRequest implements OptionsClassProvider {
   public TopLevelArtifactContext getTopLevelArtifactContext() {
     return new TopLevelArtifactContext(
         getOptions(ExecutionOptions.class).testStrategy.equals("exclusive"),
-        determineOutputGroups());
-  }
-
-  private ImmutableSortedSet<String> determineOutputGroups() {
-    Set<String> current = Sets.newHashSet();
-
-    boolean overridesDefaultOutputGroups = false;
-    for (String outputGroup : getBuildOptions().outputGroups) {
-      overridesDefaultOutputGroups |= !(outputGroup.startsWith("+") || outputGroup.startsWith("-"));
-    }
-    if (!overridesDefaultOutputGroups) {
-      current.addAll(OutputGroupProvider.DEFAULT_GROUPS);
-    }
-
-    for (String outputGroup : getBuildOptions().outputGroups) {
-      if (outputGroup.startsWith("+")) {
-        current.add(outputGroup.substring(1));
-      } else if (outputGroup.startsWith("-")) {
-        current.remove(outputGroup.substring(1));
-      } else {
-        current.add(outputGroup);
-      }
-    }
-
-    return ImmutableSortedSet.copyOf(current);
+        OutputGroupProvider.determineOutputGroups(getBuildOptions().outputGroups));
   }
 
   public ImmutableSortedSet<String> getMultiCpus() {
-- 
cgit v1.2.3