From da57492887aa13b2bad2af2b0f9de25b1c87b446 Mon Sep 17 00:00:00 2001 From: Vladimir Moskva Date: Wed, 5 Oct 2016 16:36:49 +0000 Subject: Proper error messages when built-in rule attributes are overridden #1811 -- MOS_MIGRATED_REVID=135241715 --- .../java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/main/java/com/google/devtools/build/lib/analysis') diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java index 48cb299a74..eb49821885 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java @@ -161,6 +161,8 @@ public class BaseRuleClasses { */ public static RuleClass.Builder commonCoreAndSkylarkAttributes(RuleClass.Builder builder) { return builder + .add(attr("name", STRING) + .nonconfigurable("Rule name")) // The visibility attribute is special: it is a nodep label, and loading the // necessary package groups is handled by {@link LabelVisitor#visitTargetVisibility}. // Package groups always have the null configuration so that they are not duplicated -- cgit v1.2.3