From 3e951fcb946b9f8efdef7a84a2fb0fe03ede010e Mon Sep 17 00:00:00 2001 From: gregce Date: Wed, 23 May 2018 12:26:54 -0700 Subject: Rename PatchTransition.apply to PatchTransiton.patch. This unclashes with the incoming ConfigurationTransition.apply method described in https://docs.google.com/document/d/1_UJKmAQ9EE8i3Pl0il3YLTYr-Q9EKYYyLatt2zohfyM/edit#heading=h.96gongkwg852. PiperOrigin-RevId: 197769784 --- .../devtools/build/lib/analysis/config/ConfigurationResolver.java | 2 +- .../com/google/devtools/build/lib/analysis/config/HostTransition.java | 2 +- .../lib/analysis/config/transitions/ComposingPatchTransition.java | 2 +- .../lib/analysis/config/transitions/ComposingSplitTransition.java | 2 +- .../devtools/build/lib/analysis/config/transitions/NoTransition.java | 2 +- .../build/lib/analysis/config/transitions/NullTransition.java | 2 +- .../build/lib/analysis/config/transitions/PatchTransition.java | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/analysis/config') diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigurationResolver.java b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigurationResolver.java index 862bdbeade..677c028303 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigurationResolver.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/ConfigurationResolver.java @@ -427,7 +427,7 @@ public final class ConfigurationResolver { List result; if (transition instanceof PatchTransition) { // TODO(bazel-team): safety-check that this never mutates fromOptions. - result = ImmutableList.of(((PatchTransition) transition).apply(fromOptions)); + result = ImmutableList.of(((PatchTransition) transition).patch(fromOptions)); } else if (transition instanceof SplitTransition) { List toOptions = ((SplitTransition) transition).split(fromOptions); if (toOptions.isEmpty()) { diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/HostTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/HostTransition.java index b62ce78bc4..3fef8a2d73 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/HostTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/HostTransition.java @@ -29,7 +29,7 @@ public final class HostTransition implements PatchTransition { } @Override - public BuildOptions apply(BuildOptions options) { + public BuildOptions patch(BuildOptions options) { if (options.get(BuildConfiguration.Options.class).isHost) { // If the input already comes from the host configuration, just return the existing values. // diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingPatchTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingPatchTransition.java index 635cab4b47..1fec601858 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingPatchTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingPatchTransition.java @@ -49,7 +49,7 @@ public class ComposingPatchTransition implements PatchTransition { } @Override - public BuildOptions apply(BuildOptions options) { + public BuildOptions patch(BuildOptions options) { return Iterables.getOnlyElement(delegate.split(options)); } diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingSplitTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingSplitTransition.java index 70c3bf8e70..69970c21c1 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingSplitTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingSplitTransition.java @@ -118,7 +118,7 @@ public class ComposingSplitTransition implements SplitTransition { // TODO(gregce): move this somewhere more general. This isn't intrinsic to composed splits. static List apply(BuildOptions fromOptions, ConfigurationTransition transition) { if (transition instanceof PatchTransition) { - return ImmutableList.of(((PatchTransition) transition).apply(fromOptions)); + return ImmutableList.of(((PatchTransition) transition).patch(fromOptions)); } else if (transition instanceof SplitTransition) { SplitTransition split = (SplitTransition) transition; List splitOptions = split.split(fromOptions); diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NoTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NoTransition.java index 793edafd3e..a05f6b5414 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NoTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NoTransition.java @@ -24,7 +24,7 @@ public final class NoTransition implements PatchTransition { private NoTransition() {} @Override - public BuildOptions apply(BuildOptions options) { + public BuildOptions patch(BuildOptions options) { return options; } } diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NullTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NullTransition.java index 0d7156b51e..a26d660d13 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NullTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NullTransition.java @@ -25,7 +25,7 @@ public class NullTransition implements PatchTransition { } @Override - public BuildOptions apply(BuildOptions options) { + public BuildOptions patch(BuildOptions options) { throw new UnsupportedOperationException( "This is only referenced in a few places, so it's easier and more efficient to optimize " + "Blaze's transition logic in the presence of null transitions vs. actually call this " diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/PatchTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/PatchTransition.java index 451148ee60..1fdfa95fd3 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/PatchTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/PatchTransition.java @@ -33,7 +33,7 @@ import com.google.devtools.build.lib.analysis.config.BuildOptions; * private MyTransition() {} * * {@literal @}Override - * public BuildOptions apply(BuildOptions options) { + * public BuildOptions patch(BuildOptions options) { * BuildOptions toOptions = options.clone(); * // Change some setting on toOptions * return toOptions; @@ -57,5 +57,5 @@ public interface PatchTransition extends ConfigurationTransition { * MODIFY THIS VARIABLE WITHOUT CLONING IT FIRST. * @return the options representing the desired post-transition configuration */ - BuildOptions apply(BuildOptions options); + BuildOptions patch(BuildOptions options); } -- cgit v1.2.3