From d5064165bb69cf9decdd3143db52aacf9c78011b Mon Sep 17 00:00:00 2001 From: kush Date: Tue, 28 Nov 2017 14:37:19 -0800 Subject: Make check_fileset_dependencies_recursively flag a no-op. We will always behave as if this flag is true. RELNOTES: None PiperOrigin-RevId: 177219652 --- .../build/lib/analysis/config/BuildConfiguration.java | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java') diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java index 332f4c17dc..23094fb938 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java @@ -758,18 +758,9 @@ public class BuildConfiguration implements BuildEvent { defaultValue = "true", category = "semantics", documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, - deprecationWarning = "Setting this to false is unsupported and will go away soon as it leads " - + "to incorrect results. Please contact kush@ with your use case if you need " - + "to continue setting this flag to false. If you're setting this to true then stop " - + "setting this flag to stop this warning.", - effectTags = { OptionEffectTag.AFFECTS_OUTPUTS }, - help = - "If false, fileset targets will, whenever possible, create " - + "symlinks to directories instead of creating one symlink for each " - + "file inside the directory. Disabling this will significantly " - + "speed up fileset builds, but targets that depend on filesets will " - + "not be rebuilt if files are added, removed or modified in a " - + "subdirectory which has not been traversed." + deprecationWarning = "This flag is a no-op and fileset dependencies are always checked " + + "to ensure correctness of builds.", + effectTags = { OptionEffectTag.AFFECTS_OUTPUTS } ) public boolean checkFilesetDependenciesRecursively; @@ -1869,10 +1860,6 @@ public class BuildConfiguration implements BuildEvent { return options.legacyExternalRunfiles; } - public boolean getCheckFilesetDependenciesRecursively() { - return options.checkFilesetDependenciesRecursively; - } - public boolean getSkyframeNativeFileset() { return options.skyframeNativeFileset; } -- cgit v1.2.3