From e70aafe68eebfd4f7dedf3cccd19deae72d29db6 Mon Sep 17 00:00:00 2001 From: cparsons Date: Wed, 28 Feb 2018 12:16:38 -0800 Subject: Deprecate and remove several uses of the 'values' map in NativeInfo subclasses. These subclasses should be using @SkylarkCallable(structField = true) instead This is a bit of a memory win, as there is now no need to store field information twice. There are still a couple of stragglers that are more difficult, namely ToolchainInfo and DefaultInfo. Their APIs will likely need some more extensive revamping before proceeding. RELNOTES: None. PiperOrigin-RevId: 187364392 --- src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java') diff --git a/src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java b/src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java index 9af9811a50..82c04c259e 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/DefaultInfo.java @@ -15,7 +15,6 @@ package com.google.devtools.build.lib.analysis; import com.google.common.collect.ImmutableCollection; import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; import com.google.devtools.build.lib.actions.Artifact; import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.events.Location; @@ -62,8 +61,7 @@ public final class DefaultInfo extends NativeInfo { RunfilesProvider runfilesProvider, FileProvider fileProvider, FilesToRunProvider filesToRunProvider) { - // Fields map is not used here to prevent memory regression - super(PROVIDER, ImmutableMap.of()); + super(PROVIDER); this.runfilesProvider = runfilesProvider; this.fileProvider = fileProvider; this.filesToRunProvider = filesToRunProvider; -- cgit v1.2.3