From cf49294141665da4f4d005610c816fc591c08c22 Mon Sep 17 00:00:00 2001 From: Lukacs Berki Date: Mon, 29 Jun 2015 07:48:59 +0000 Subject: Remove BuildConfiguration.cacheKey() and replace .shortCacheKey() with a .checksum() method that is computed from the checksum of the build options. Also remove Fragment.cacheKey() and Fragment.getName(). The reasoning is that within a single build, if two BuildConfigurations share the same BuildOptions, they must be the same because BuildConfiguration can only be a function of BuildOptions, specific targets (which stay the same during a build) and BlazeDirectories (which stay the same during the lifetime of a server). Between different builds if the configurations are recreated, they will always be considered different because Java reference equality (==) is used for comparing BuildConfigurations. Also remove "Serializable" tags from configuration-related things. -- MOS_MIGRATED_REVID=97107881 --- src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java') diff --git a/src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java b/src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java index ab59f635bf..7cf9ae7ac1 100644 --- a/src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java +++ b/src/main/java/com/google/devtools/build/lib/actions/ActionOwner.java @@ -56,7 +56,7 @@ public interface ActionOwner { *

These requirements exist so that {@link ActionOwner} instances are consistent with * {@code BuildView.ActionOwnerIdentity(ConfiguredTargetValue)}. */ - String getConfigurationShortCacheKey(); + String getConfigurationChecksum(); /** * Returns the target kind (rule class name) for this ActionOwner, if any; null otherwise. -- cgit v1.2.3